Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide top level methods to set custom http handlers #446

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

sarahsnow1
Copy link
Member

@sarahsnow1 sarahsnow1 commented Sep 7, 2017

Overview

This is the first of two PRs needed to bring first class support for providing custom http headers and parameters to search, routing, and tile requests. This work adds MapzenSearch#setHttpHandler(MapzenSearchHttpHandler ), MapzenRouter#setHttpHandler(MapzenRouterHttpHandler ), and MapzenMap#setHttpHandler(MapzenMapHttpHandler ) methods.

Proposed Changes

  • Adds top level APIs to set custom http parameters and headers
  • Adds relevant test coverage
  • Adds SDK LogLevel enum for mapping to internal implementation log level (future PR will provide ability to set log level on search and map handlers as well Allow setting custom log level for search and tile requests #445)
  • Updates MapzenRouterHttpHandler to allow setting base url and log level

A follow up PR will provide support for pulling the API key from MapzenManager automatically (#444)

Closes #443

@sarahsnow1
Copy link
Member Author

I'm going to merge this so I can start on #444. I'll address any issues in the PR for that (related) work.

@sarahsnow1 sarahsnow1 merged commit bf93f44 into master Sep 7, 2017
@sarahsnow1 sarahsnow1 deleted the 443-setHttpHandler branch September 7, 2017 21:04
Copy link
Member

@tallytalwar tallytalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants