Merge pull request #345 from mapzen/chuck/dont-upload-traces-less-tha…

…n-50-meters Remove check for minimum number of points (no longer needed)
mapzen · Nov 5, 2014 · deb805e · deb805e
2 parents 449f805 + bc6449c
commit deb805e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 22 deletions.
diff --git a/src/main/java/com/mapzen/open/core/DataUploadService.java b/src/main/java/com/mapzen/open/core/DataUploadService.java
@@ -68,7 +68,6 @@
 import static org.apache.http.protocol.HTTP.UTF_8;
 
 public class DataUploadService extends Service {
-    private static final int MIN_NUM_TRACKING_POINTS = 10;
     private static final int MIN_RANGE_IN_METERS = 50;
 
     private static final String RANGE_QUERY_EXT = " from "
@@ -217,10 +216,6 @@ public DOMSource getDocument(String groupId) {
             }
             trkElement.appendChild(trksegElement);
             Element documentElement =  document.getDocumentElement();
-            int numberOfPoints = documentElement.getElementsByTagName("ele").getLength();
-            if (numberOfPoints < MIN_NUM_TRACKING_POINTS) {
-                return null;
-            }
             if (calculateMaxRange(groupId) < MIN_RANGE_IN_METERS) {
                 return null;
             }

diff --git a/src/test/java/com/mapzen/open/core/DataUploadServiceTest.java b/src/test/java/com/mapzen/open/core/DataUploadServiceTest.java
@@ -159,23 +159,6 @@ public void shouldGenerateGPX_shouldSubmit() throws Exception {
                 eq(expectedRouteDescription));
     }
 
-    @Test
-    public void shouldGenerateGPX_shouldNotSubmit() throws Exception {
-        Token token = new Token("stuff", "fun");
-        app.setAccessToken(token);
-
-        String expectedGroupId = "test_route";
-        String expectedRouteDescription = "does not matter";
-        fillLocationsTable(expectedGroupId, 4);
-        DataUploadService spy = spy(service);
-        spy.onStartCommand(null, 0, 0);
-        verify(spy).generateGpxXmlFor(expectedGroupId, expectedRouteDescription);
-        verify(spy).getDocument(expectedGroupId);
-        verify(spy, never()).submitCompressedFile(any(ByteArrayOutputStream.class),
-                eq(expectedGroupId),
-                eq(expectedRouteDescription));
-    }
-
     @Test
     public void shouldHaveLocationsFromAllRoutesInGroup() throws Exception {
         String groupId = "test-group-id";