Skip to content

Commit

Permalink
drivers: Intel: hda-dma: lower log level of "underrun detected"
Browse files Browse the repository at this point in the history
Lower the log level of `tr_err(&hdma_tr, "hda_dma_link_check_xrun():
underrun detected");` to `tr_warn()`.

Underruns are expected when testing pause/start and these errors can
hide other, "real", not expected errors; more details in
thesofproject/sof-test#1188

This "fixes" 2019 commit 293dfe2 ("hda-dma: refactor xrun
handling")

Note this driver is not in the main branch anymore, removed by commit
59028ad ("drivers: Intel: remove Intel XTOS drivers")

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
  • Loading branch information
marc-hb committed May 9, 2024
1 parent 7b46ae6 commit e8cac2e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/drivers/intel/hda/hda-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ static int hda_dma_link_check_xrun(struct dma_chan_data *chan)
uint32_t dgcs = dma_chan_reg_read(chan, DGCS);

if (chan->direction == DMA_DIR_MEM_TO_DEV && dgcs & DGCS_BUR) {
tr_err(&hdma_tr, "hda_dma_link_check_xrun(): underrun detected");
tr_warn(&hdma_tr, "hda_dma_link_check_xrun(): underrun detected");
dma_chan_reg_update_bits(chan, DGCS, DGCS_BUR, DGCS_BUR);
} else if (chan->direction == DMA_DIR_DEV_TO_MEM && dgcs & DGCS_BOR) {
tr_err(&hdma_tr, "hda_dma_link_check_xrun(): overrun detected");
Expand Down

0 comments on commit e8cac2e

Please sign in to comment.