Skip to content

Commit

Permalink
app/prj.conf: stop forcing CONFIG_OUTPUT_DISASSEMBLY=y
Browse files Browse the repository at this point in the history
This reverts 8f60180 ("app: enable OUTPUT_DISASSEMBLY for Zephyr
builds")

The disassembly is useful in some contexts but can't be parallelized and
takes an enormous amount of time. On my system OUTPUT_DISASSEMBLY
almost doubles the compilation time!

Quoting Zephyr commit cc5763344709:

> This on-by-default option takes the majority of "link" time. If people
> need the disassembly, they can turn it on.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
  • Loading branch information
marc-hb committed Feb 1, 2024
1 parent 728c38f commit ea3cdc6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions app/prj.conf
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ CONFIG_BUILD_OUTPUT_BIN=n
# and usage in xtensa-build-zephyr.py
CONFIG_BUILD_OUTPUT_STRIPPED=y

# Generate zephyr.lst file
CONFIG_OUTPUT_DISASSEMBLY=y

CONFIG_HAVE_AGENT=n

# Since Zephyr commit f0daf904bb0202c PICOLIBC is the new default.
Expand Down
2 changes: 1 addition & 1 deletion scripts/xtensa-build-zephyr.py
Original file line number Diff line number Diff line change
Expand Up @@ -943,7 +943,7 @@ class InstFile:
InstFile("include/generated/sof_versions.h", "sof_versions.h",
gzip=False, txt=True),
InstFile(BIN_NAME + ".elf"),
InstFile(BIN_NAME + ".lst", txt=True),
InstFile(BIN_NAME + ".lst", txt=True, optional=True),
InstFile(BIN_NAME + ".map", txt=True),

# CONFIG_BUILD_OUTPUT_STRIPPED
Expand Down

0 comments on commit ea3cdc6

Please sign in to comment.