Merge pull request #265 from marceloatg/develop

Test ID data parameter added to some components
marceloatg · May 5, 2024 · 568b5e5 · 568b5e5
2 parents 19a1276 + a353d1c
commit 568b5e5
Show file tree

Hide file tree

Showing 6 changed files with 88 additions and 85 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -7,7 +7,8 @@
     "exports": {
         ".": {
             "import": "./dist/vuetning.es.js",
-            "require": "./dist/vuetning.umd.js"
+            "require": "./dist/vuetning.umd.js",
+            "types": "./dist/main.d.ts"
         },
         "./style.css": "./dist/style.css"
     },
@@ -32,7 +33,7 @@
         "numeral": "^2.0.6",
         "scrollparent": "^2.1.0",
         "uuid": "^9.0.1",
-        "vue": "^3.4.23",
+        "vue": "^3.4.26",
         "vue-observe-visibility": "^2.0.0-alpha.1"
     },
     "devDependencies": {
@@ -47,10 +48,10 @@
         "npm-run-all2": "^6.1.2",
         "postcss": "^8.4.38",
         "postcss-prefix-selector": "^1.16.1",
-        "sass": "^1.75.0",
+        "sass": "^1.76.0",
         "typescript": "~5.4.0",
-        "vite": "^5.2.10",
-        "vitepress": "^1.1.3",
+        "vite": "^5.2.11",
+        "vitepress": "^1.1.4",
         "vue-tsc": "^2.0.13"
     }
 }
diff --git a/src/components/slds-button/slds-button.vue b/src/components/slds-button/slds-button.vue
@@ -32,7 +32,7 @@
 
         <!-- Spinner -->
         <span v-if="showSpinner">
-            <span class="slds-spinner slds-spinner_x-small" :class="spinnerClassNames">
+            <span :class="spinnerClassNames" data-testid="spinner">
                 <span class="slds-spinner__dot-a"/>
                 <span class="slds-spinner__dot-b"/>
             </span>
@@ -185,7 +185,7 @@ export default defineComponent({
          * The CSS class names for the spinner.
          */
         spinnerClassNames(): string {
-            let classNames = ""
+            let classNames = "slds-spinner slds-spinner_x-small"
 
             // Spinner theme
             if (this.showSpinner && (this.brand || this.destructive || this.success)) classNames += " slds-spinner-white"

diff --git a/src/components/slds-combobox/slds-combobox.vue b/src/components/slds-combobox/slds-combobox.vue
@@ -99,6 +99,7 @@
                         :filter="filter"
                         :focused-option="focusedOption"
                         :is-open="isOpen"
+                        :length="length"
                         :options="filteredOptions"
                         :selected-option="selectedOption"
                         :show-spinner="showSpinner"

diff --git a/src/components/slds-form-element/slds-form-element.vue b/src/components/slds-form-element/slds-form-element.vue
@@ -31,16 +31,16 @@
         </div>
 
         <!-- Inline help -->
-        <div v-if="hasInlineHelp" class="slds-form-element__help">
+        <div v-if="hasInlineHelp" class="slds-form-element__help" data-testid="help">
             <slot name="help">
                 {{ help }}
             </slot>
         </div>
 
         <!-- Error messages -->
-        <div v-if="hasErrorMessages" class="slds-form-element__help">
+        <div v-if="hasErrorMessages" class="slds-form-element__help" data-testid="errors">
             <slot name="error">
-                <p v-for="error of errors" :key="error.$uid">
+                <p v-for="error of errors" :key="error.$uid" data-testid="error">
                     {{ error.$message }}
                 </p>
             </slot>

diff --git a/src/components/slds-picklist/slds-picklist.vue b/src/components/slds-picklist/slds-picklist.vue
@@ -55,6 +55,7 @@
                     <slds-dropdown
                         :focused-option="focusedOption"
                         :is-open="isOpen"
+                        :length="length"
                         :options="options"
                         :selected-option="selectedOption"
                         :show-spinner="showSpinner"