Revert "Revert "Add comment support to JPQL console (#16)" (#17)"

This reverts commit 4cd1c08

modules/core/src/de/diedavids/cuba/runtimediagnose/db/DbQueryParser.groovy

@@ -27,6 +27,7 @@ import net.sf.jsqlparser.statement.update.Update
 import org.springframework.stereotype.Component
 
 import javax.inject.Inject
+import java.util.regex.Pattern
 
 @Component
 class DbQueryParser {
@@ -65,7 +66,8 @@ class DbQueryParser {
 
 
         if (DiagnoseType.JPQL == diagnoseType) {
-            analyseJpql(queryString)
+            String queryStringWithoutComments = excludeComments(queryString)
+            analyseJpql(queryStringWithoutComments)
         }
 
         statements
@@ -109,4 +111,11 @@ class DbQueryParser {
 
         containsIllegalOperation
     }
+
+    String excludeComments(String queryString) {
+        Pattern.compile('/\\*.*?\\*/', Pattern.DOTALL)
+                .matcher(queryString)
+                .replaceAll('')
+                .replaceAll('--.*\n?', '')
+    }
 }

modules/core/test/de/diedavids/cuba/runtimediagnose/db/DbQueryParserSpec.groovy

@@ -9,6 +9,7 @@ import net.sf.jsqlparser.statement.Statements
 import net.sf.jsqlparser.statement.drop.Drop
 import net.sf.jsqlparser.statement.insert.Insert
 import spock.lang.Specification
+import spock.lang.Unroll
 
 class DbQueryParserSpec extends Specification {
 
@@ -135,4 +136,69 @@ class DbQueryParserSpec extends Specification {
         dropStatement instanceof SetStatement
         dropStatement.toString() == "SET OPTION = VALUE"
     }
+
+    @Unroll
+    def "excludeComments excludes single line and multiline comments from SQL query (#type)"() {
+        given:
+        def escape = { String str -> str.replace('*', '\\*')}
+
+        when:
+        String result = sut.excludeComments(query)
+
+        then:
+        result ==~ /\s*${escape("select * from SEC_USER")}\s*/
+
+        where:
+        query << [
+"""-- first comment
+select * from SEC_USER""",
+
+"""
+/* multi-line
+   comment*/
+select * from SEC_USER""",
+
+"""
+/* multi-line
+   line */
+-- single line comment
+select * from SEC_USER"""]
+        type << ["single line", "multi-line", "mixing"]
+    }
+
+    @Unroll
+    def "analyseQueryString exludes comments in JPQL queries (#type)"() {
+        given:
+        def localSut = new DbQueryParser() {
+            @Override
+            void analyseJpql(String queryString) {}
+        }
+        localSut.with {
+            configuration = runtimeDiagnoseConfiguration
+            messages = messages
+        }
+
+        when:
+        Statements result = localSut.analyseQueryString(query, DiagnoseType.JPQL)
+
+        then:
+        result.statements[0].toString() == "select * from SEC_USER".toUpperCase()
+
+        where:
+        query << [
+"""-- first comment
+select * from SEC_USER""",
+
+"""
+/* multi-line
+   comment*/
+select * from SEC_USER""",
+
+"""
+/* multi-line
+   line */
+-- single line comment
+select * from SEC_USER"""]
+        type << ["single line", "multi-line", "mixing"]
+    }
 }