Fix occasional error while unmarshalling Apple id_token #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaronius
changed the title
|
Not sure why tests are failing 🤔 |
|
Hi @techknowlogick, sorry for direct ping, haven't seen you here for a while, and the mentioned issue seems to be affecting more Apple users recently. If I can do anything to help you, just let me know. Thank you! |
Closed
|
thanks @yaronius, could you merge in the recent push to master, as I've updated stuff around tests/min go version |
|
Thank you @techknowlogick, done, now all tests pass 🎉 |
|
Thanks! |
|
I'll (hopefully) cut a release soon. |
|
This has been driving us crazy! Thanks so much for the fix. Also looking forward to a release soon! |
|
@dstapleton92 thanks for the reminder. I just cut the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! According to Apple documentation on the ID token it turns out that some claims could be either boolean or string representing boolean. In this library we always parse one of these claims (
is_private_email) as a string (notice the tags on this line) and sometimes (when Apple actually sends boolean value) it results in the following error:json: invalid use of ,string struct tag, trying to unmarshal unquoted value into bool. I recently noticed an increase in the amount of such errors, probably now Apple uses boolean more frequently. This PR fixes that by detecting the value from token and handling it appropriately.