This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
fix for adding a 'similar' named search option #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grtjn Please review. :) |
|
Great reuse of the default search route! I still wonder if we need a separate search options for this, but looks great otherwise.. |
|
hmm, we should have merged this. It starts showing commits from the next PR. Perhaps use feature branches next time. |
|
PR #9 includes changes of this PR, closing this one.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for migrating from a direct fetch to extsimilar to using a custom constraint to get 'similar' results.