Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hybrid search duplicate test error #253

Merged
merged 12 commits into from
Sep 17, 2024
Merged

Conversation

vicilliar
Copy link
Contributor

@vicilliar vicilliar commented Sep 12, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)

  • 3 hybrid search tests are broken
  • py-marqo cloud integration tests run every push to PR
  • What is the new behavior (if this is a feature change)?
  • 2 hybrid search tests skip hit ID checks (due to replicas causing inconsistency). These will be uncommented when inconsistency is fixed.
  • Duplicate test was split into a structured and unstructured version.
  • Cloud integration test run condition was changed to just manual run
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    None

  • Other information:

@vicilliar vicilliar changed the title Cloud test fixes for 2.11.4 client Fix hybrid search duplicate test error Sep 16, 2024
@vicilliar vicilliar merged commit 02d2010 into mainline Sep 17, 2024
4 of 5 checks passed
@vicilliar vicilliar deleted the joshua/2.11.4-client-2 branch September 17, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants