Add media download headers in py-marqo #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
farshidz
requested changes
Oct 28, 2024
wanliAlex
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
farshidz
previously approved these changes
Oct 28, 2024
farshidz
previously approved these changes
Oct 28, 2024
wanliAlex
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
approved these changes
Oct 29, 2024
papa99do
force-pushed
the
li/add-media-download-headers
branch
from
2be4eb4
to
77bea49
Compare
papa99do
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
we are still using image_download_headers
What is the new behavior (if this is a feature change)?
we now use media_download_headers and make image_download_headers deprecated
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: