Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1] Dna exten/itp #313

Merged
merged 22 commits into from
Sep 26, 2023
Merged

[1] Dna exten/itp #313

merged 22 commits into from
Sep 26, 2023

Conversation

fgrunewald
Copy link
Member

@fgrunewald fgrunewald commented Apr 18, 2023 •
edited
Loading

To Do

  • add tests for errors in gen_dna
  • add tests for missing edge warning
  • fix ig parsing 1 line

@fgrunewald fgrunewald requested review from jan-stevens and removed request for jan-stevens August 16, 2023 11:16
@fgrunewald fgrunewald changed the title Dna exten/itp [1] Dna exten/itp Aug 16, 2023
@fgrunewald fgrunewald mentioned this pull request Aug 16, 2023
Closed
@fgrunewald fgrunewald added the DNA_extension Part of the DNA extension project label Aug 16, 2023
@fgrunewald
Copy link
Member Author

@jan-stevens whenever you've got time for a review ;)

jan-stevens
jan-stevens reviewed Sep 26, 2023
View reviewed changes
polyply/src/gen_dna.py Outdated Show resolved Hide resolved
jan-stevens
jan-stevens requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@jan-stevens jan-stevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it will be very useful!
Only added some small comments.

fgrunewald and others added 2 commits September 26, 2023 14:05
@fgrunewald @jan-stevens
minor opt
c36392a 
Co-authored-by: Jan Stevens <49684318+jan-stevens@users.noreply.github.com>
@fgrunewald @jan-stevens
minor opt
f9117f5 
Co-authored-by: Jan Stevens <49684318+jan-stevens@users.noreply.github.com>
@fgrunewald fgrunewald merged commit 84d0c25 into master Sep 26, 2023
8 checks passed
@fgrunewald fgrunewald deleted the DNA-exten/itp branch September 26, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-stevens jan-stevens jan-stevens approved these changes

Assignees
No one assigned
Labels
DNA_extension Part of the DNA extension project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgrunewald @jan-stevens