Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scipy 1.11 patch #333

Merged
merged 1 commit into from
Jun 28, 2023
Merged

add scipy 1.11 patch #333

merged 1 commit into from
Jun 28, 2023

Conversation

fgrunewald
Copy link
Member

small patch to counter deprecation error

@fgrunewald fgrunewald requested a review from pckroon June 27, 2023 16:54
pckroon
pckroon reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this change? This makes positions a 1D array, rather than a 2D array containing 3 dimensional coordinates.

@fgrunewald
Copy link
Member Author

fgrunewald commented Jun 28, 2023 •
edited
Loading

@pckroon yes because scipy only supports 1D vector optimisations. The optimisation function reshapes this array into the correct dimensions.

@fgrunewald fgrunewald merged commit 75b892f into master Jun 28, 2023
8 checks passed
@fgrunewald fgrunewald deleted the fix/scipyv1.11 branch June 28, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pckroon pckroon pckroon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgrunewald @pckroon