Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1] Error pragma #337

Merged
merged 5 commits into from
Aug 15, 2023
Merged

[1] Error pragma #337

merged 5 commits into from
Aug 15, 2023

Conversation

fgrunewald
Copy link
Member

Small fix of issue #335.

jan-stevens
jan-stevens previously approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@jan-stevens jan-stevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the two small nitpicks, it looks good to me!

polyply/src/top_parser.py Show resolved Hide resolved
polyply/tests/test_top_parser.py Outdated Show resolved Hide resolved
pckroon
pckroon requested changes Aug 14, 2023
View reviewed changes
Copy link
Member

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks, looks fine in general.
Alternatively, do we want to just raise the issue, or propagate the error pragma to the output itp file?

polyply/src/top_parser.py Show resolved Hide resolved
polyply/src/top_parser.py Outdated Show resolved Hide resolved
jan-stevens

This comment was marked as duplicate.

Sign in to view

jan-stevens
jan-stevens approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@jan-stevens jan-stevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgrunewald fgrunewald changed the title Error pragma [1] Error pragma Aug 15, 2023
@fgrunewald fgrunewald merged commit 1ecd4d5 into master Aug 15, 2023
8 checks passed
@fgrunewald fgrunewald deleted the error-pragma branch August 15, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pckroon pckroon pckroon approved these changes

@jan-stevens jan-stevens jan-stevens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgrunewald @pckroon @jan-stevens