#50 resolved root issue witch was calling the ToLowerInvariant method…

… on a null object.
martial-god · Jul 4, 2024 · ff93d97 · ff93d97
1 parent 2338420
commit ff93d97
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/Benny-Scraper/CommandlineOptions.cs b/Benny-Scraper/CommandlineOptions.cs
@@ -23,13 +23,13 @@ public class CommandLineOptions
         [Option('c', "concurrent-request", Required = false, HelpText = "Set the number [INT] of concurrent requests to a website. Default is 2, value will be limited to number of CPU cores on your computer. *Some websites may block your ip if too many requests are made in a short time*")]
         public int ConcurrentRequests { get; set; }
 
-        [Option('s', "save-location", Required = false, Default = "", HelpText = "Set default save location [PATH]. Overridden by specific 'manga' or 'novel' locations if set.")]
+        [Option('s', "save-location", Required = false, HelpText = "Set default save location [PATH]. Overridden by specific 'manga' or 'novel' locations if set.")]
         public string SaveLocation { get; set; }
 
-        [Option('m', "manga-save-location", Required = false, Default = "", HelpText = "Set manga-specific save location [PATH]. Overrides 'save-location'.")]
+        [Option('m', "manga-save-location", Required = false, HelpText = "Set manga-specific save location [PATH]. Overrides 'save-location'.")]
         public string MangaSaveLocation { get; set; }
 
-        [Option('n', "novel-save-location", Required = false, Default = "", HelpText = "Set novel-specific save location [PATH]. Overrides 'save-location'.")]
+        [Option('n', "novel-save-location", Required = false, HelpText = "Set novel-specific save location [PATH]. Overrides 'save-location'.")]
         public string NovelSaveLocation { get; set; }
 
         [Option('x', "novel-extension-by-id", Required = false, HelpText = "Set Extension/File type of a saved novel by using the [ID]. 0 - EPUB, 1 - PDF, 2 -CBZ.")]

diff --git a/Benny-Scraper/Program.cs b/Benny-Scraper/Program.cs
@@ -217,17 +217,17 @@ private static async Task HandleOptionsAsync(CommandLineOptions options)
                 int extension = (int)options.MangaExtension;
                 await SetDefaultMangaExtensionAsync(extension);
             }
-            else if (string.Equals(options.SingleFile.ToLowerInvariant(), "y", StringComparison.OrdinalIgnoreCase) || string.Equals(options.SingleFile.ToLowerInvariant(), "n", StringComparison.OrdinalIgnoreCase))
+            else if (string.Equals(options.SingleFile?.ToLowerInvariant(), "y", StringComparison.OrdinalIgnoreCase) || string.Equals(options.SingleFile?.ToLowerInvariant(), "n", StringComparison.OrdinalIgnoreCase))
             {
-                bool singleFile = options.SingleFile.ToLowerInvariant() == "y";
+                bool singleFile = options.SingleFile?.ToLowerInvariant() == "y";
                 await SetSingleFileAsync(singleFile);
             }
             else if (options.ExtensionType)
             {
                 await GetDefaultMangaExtensionAsync();
             }
             else
-                Console.WriteLine("Invalid command. Please try again.");
+                Console.WriteLine("Invalid command or a parameter is missing. Please try again.");
         }
 
         private static async Task UpdateAllNovelsAsync(CancellationToken cancellation)

diff --git a/Benny-Scraper/Properties/launchSettings.json b/Benny-Scraper/Properties/launchSettings.json
@@ -6,7 +6,6 @@
     },
     "Benny-Scraper": {
       "commandName": "Project",
-      "commandLineArgs" : "-s",
       "nativeDebugging": true
     }
   }