module-info are added; structrure is updated to conform M2 #1004

solomax · 2023-10-15T06:09:08Z

No description provided.

martin-g · 2023-10-15T20:07:06Z

bootstrap-sass/pom.xml

        <antlr.version>3.5.2</antlr.version>
    </properties>

    <dependencies>
        <dependency>
-            <groupId>ua.kasta</groupId>
+            <groupId>io.bit3</groupId>


I think we moved from bit3 to kasta because bit3 was abandoned and it does not support Mac ARM64.
See #986

Mainly because of ARM - I believe it continues being abandoned in any case. The native library that is being wrapped here is no longer developed as far as I remember...

I'll revert this change

BUT according to https://mvnrepository.com/artifact/ua.kasta/jsass ua.kasta:jsass seems to be dead as well :(((
It is "one-release-repo" :((((

There is little point in maintaining a java wrapper for a library which is dead. See notice on jsass repo:

libsass has been declared deprecated and there will be no further development! This also ends the further development of jsass. It is not yet clear whether there will ever be an implementation based on the Sass embedded protocol. I recommend switching to Webpack or similar technologies! This project will continue to be maintained for the time being and compatibility with newer Java versions will be ensured. But please do not expect any further development on my part.

fwiw I have switched to using sass with the maven-frontend-plugin some time back.

I have switched to using sass with the maven-frontend-plugin

I did the same :)

martin-g · 2023-10-16T06:38:44Z

@solomax Anything else you want to add here or it is ready to be merged ?

solomax · 2023-10-16T08:22:05Z

@solomax Anything else you want to add here or it is ready to be merged ?

Let's wait for the M2 release to drop SNAPSHOT dependency :)
Meanwhile I'll try to create PRs for jquery.selectors and wicket.webjars so they will have Automatic module anmes (or be converted to JMS)

This will make it easier to release. Currently WB depends on WS-Annotation, and some other WS projects depend on WB. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

martin-g · 2023-10-19T13:19:32Z

@solomax Ready to go ?

martin-g · 2023-10-19T13:23:13Z

I wonder whether we need to add opens too ? Like WICKET-7081

solomax · 2023-10-19T15:06:30Z

I wonder whether we need to add opens too ? Like WICKET-7081

I'll try to check later this week or early next week :)

solomax · 2023-10-19T15:07:48Z

@solomax Ready to go ?

yes IMO this one can be released (so people can test it :)))

solomax · 2023-10-19T16:11:40Z

bootstrap-samples/src/main/java/de/agilecoders/wicket/samples/WicketApplication.java

@@ -93,7 +111,7 @@ public void init() {

        optimizeForWebPerformance();

-        new AnnotatedMountScanner().scanPackage("de.agilecoders.wicket.samples.pages").mount(this);


Actually this class wasn't dropped: https://github.com/wicketstuff/core/blob/master/annotation/src/main/java/org/wicketstuff/annotation/scan/AnnotatedMountScanner.java

my local build is green ... :(

I can run bootstrap-samples using mvn jetty:run

Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8) Maven home: /opt/maven Java version: 17.0.8.1, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.15.0-86-generic", arch: "amd64", family: "unix"

martin-g · 2023-10-19T17:18:25Z

On Thu, 19 Oct 2023 at 19:11, Maxim Solodovnik ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In bootstrap-samples/src/main/java/de/agilecoders/wicket/samples/WicketApplication.java <#1004 (comment)> : > @@ -93,7 +111,7 @@ public void init() { optimizeForWebPerformance(); - new AnnotatedMountScanner().scanPackage("de.agilecoders.wicket.samples.pages").mount(this); Actually this class wasn't dropped: https://github.com/wicketstuff/core/blob/master/annotation/src/main/java/org/wicketstuff/annotation/scan/AnnotatedMountScanner.java my local build is green ... :(

Why green build is a bad thing ? :-) I just removed the usage of AnnotatedMountScanner in WB. Now there is no dependency to wicketstuff. I can run bootstrap-samples using mvn jetty:run

…

Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8) Maven home: /opt/maven Java version: 17.0.8.1, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.15.0-86-generic", arch: "amd64", family: "unix" — Reply to this email directly, view it on GitHub <#1004 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABYUQTUJRNP6RXXAGYVHS3YAFGMTAVCNFSM6AAAAAA6AYZRQGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOBYGE2TENBVGA> . You are receiving this because you commented.Message ID: ***@***.***>

solomax · 2023-10-20T02:32:55Z

Why green build is a bad thing ? :-) I just removed the usage of AnnotatedMountScanner in WB. Now there is no dependency to wicketstuff. I can run bootstrap-samples using mvn jetty:run

green build is not so bad :)
different results - is something need to be investigated IMO :))

martin-g · 2023-10-20T06:48:56Z

Ah, you meant the issue with maven-source-plugin.
mvn help:effective-pom showed that there are two executions for this plugin. One of them comes from the parent pom (Sonatype OSS) - with id attach-sources

martin-g · 2023-10-20T06:57:25Z

yes IMO this one can be released

Done!

solomax added 2 commits October 15, 2023 13:08

module-info are added; structrure is updated to conform M2

1ca7d0c

Code clean-up

ecc4e8f

martin-g reviewed Oct 15, 2023

View reviewed changes

io.bit3 -> ua.kasta

8347fc6

martin-g approved these changes Oct 16, 2023

View reviewed changes

solomax and others added 2 commits October 19, 2023 19:53

Dependencies are updated

eeb1e7d

Get rid of the dependency to WicketStuff-annotation

0da19b4

This will make it easier to release. Currently WB depends on WS-Annotation, and some other WS projects depend on WB. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

solomax commented Oct 19, 2023

View reviewed changes

martin-g merged commit 0deffcc into martin-g:wicket-10.x-bootstrap-5.x Oct 20, 2023
2 checks passed

solomax deleted the jms-and-m2 branch October 22, 2023 07:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

module-info are added; structrure is updated to conform M2 #1004

module-info are added; structrure is updated to conform M2 #1004

solomax commented Oct 15, 2023

martin-g Oct 15, 2023

reckart Oct 15, 2023 •

edited

Loading

solomax Oct 16, 2023

reckart Oct 16, 2023

reckart Oct 16, 2023

solomax Oct 19, 2023 •

edited

Loading

martin-g commented Oct 16, 2023

solomax commented Oct 16, 2023

martin-g commented Oct 19, 2023

martin-g commented Oct 19, 2023

solomax commented Oct 19, 2023

solomax commented Oct 19, 2023

solomax Oct 19, 2023

martin-g commented Oct 19, 2023 via email

solomax commented Oct 20, 2023

martin-g commented Oct 20, 2023

martin-g commented Oct 20, 2023

		@@ -93,7 +111,7 @@ public void init() {

		optimizeForWebPerformance();

		new AnnotatedMountScanner().scanPackage("de.agilecoders.wicket.samples.pages").mount(this);

module-info are added; structrure is updated to conform M2 #1004

module-info are added; structrure is updated to conform M2 #1004

Conversation

solomax commented Oct 15, 2023

martin-g Oct 15, 2023

Choose a reason for hiding this comment

reckart Oct 15, 2023 • edited Loading

Choose a reason for hiding this comment

solomax Oct 16, 2023

Choose a reason for hiding this comment

reckart Oct 16, 2023

Choose a reason for hiding this comment

reckart Oct 16, 2023

Choose a reason for hiding this comment

solomax Oct 19, 2023 • edited Loading

Choose a reason for hiding this comment

martin-g commented Oct 16, 2023

solomax commented Oct 16, 2023

martin-g commented Oct 19, 2023

martin-g commented Oct 19, 2023

solomax commented Oct 19, 2023

solomax commented Oct 19, 2023

solomax Oct 19, 2023

Choose a reason for hiding this comment

martin-g commented Oct 19, 2023 via email

solomax commented Oct 20, 2023

martin-g commented Oct 20, 2023

martin-g commented Oct 20, 2023

reckart Oct 15, 2023 •

edited

Loading

solomax Oct 19, 2023 •

edited

Loading