Synchronize border and color classes with BS 5.3.2, add Color and background helper, behavior improvements #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrozkovec
changed the title
vrozkovec
changed the title
martin-g
approved these changes
Nov 27, 2023
|
Thank you, @vrozkovec ! |
|
@martin-g can you please cherry-pick this into |
martin-g
pushed a commit
that referenced
this pull request
Nov 27, 2023
…kground helper, behavior improvements (#1005) * Fix border classes, add new colors for BS5 * Align colors with BS 5 https://getbootstrap.com/docs/5.3/utilities/colors/ * Javadoc fix * Add new implementation to accommodate Color and background helper https://getbootstrap.com/docs/5.3/helpers/color-background/ * Allow BorderBehavior to use IModel, add Width enum * ColorBehavior can accept IModel<Color> * BackgroundColorBehavior now accepts IModel<Color> * ColorAndBackgroundBehavior now accepts IModel<Color> * Add getters and setters for color (cherry picked from commit 73aa879)
|
Done! Thanks for the reminder, @solomax ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.