Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FontAwesomeSettings.java correct arrow icons #1067

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

x-paphio
Copy link
Contributor

@x-paphio x-paphio commented Apr 3, 2024

arrow_left and arrow_right are referencing alignment icons. They should be arrows like up and down

arrow_left and arrow_right are referencing alignnement icons. They should be arrows like up and down
Copy link
Contributor

@ursjoss ursjoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@martin-g martin-g merged commit 18b2220 into martin-g:wicket-10.x-bootstrap-5.x Apr 3, 2024
2 checks passed
@martin-g
Copy link
Owner

martin-g commented Apr 3, 2024

Thank you!

@solomax
Copy link
Contributor

solomax commented Apr 4, 2024

@martin-g Shall this one be cherry-picked to wicket-9.x-bootstrap-5.x ? :))

martin-g pushed a commit that referenced this pull request Apr 4, 2024
@martin-g
Copy link
Owner

martin-g commented Apr 4, 2024

Shall this one be cherry-picked to wicket-9.x-bootstrap-5.x ? :))

Done! Thanks!

@x-paphio x-paphio deleted the patch-5 branch April 10, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants