Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap italia to version 2.8.7 #1143

Merged

Conversation

r1gm
Copy link
Contributor

@r1gm r1gm commented Sep 10, 2024

No description provided.

<groupId>org.webjars.npm</groupId>
<artifactId>design-tokens-italia</artifactId>
</exclusion>
</exclusions>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we exclude bootstrap also ?, forcing bootstrap version using current wicket-bootstrap webjar version.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this is a good idea!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<artifactId>bootstrap-italia</artifactId>
<version>${bootstrap-italia.version}</version>
<exclusions>
<exclusion> <!-- exclude dependency, because causing dependency conflict -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of conflict does it cause ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output :

Failed to execute goal on project wicket-bootstrap-themes: Could not resolve dependencies for project de.agilecoders.wicket:wicket-bootstrap-themes:bundle:7.0.7-SNAPSHOT: Failed to collect dependencies for de.agilecoders.wicket:wicket-bootstrap-themes:jar:7.0.7-SNAPSHOT: Could not resolve version conflict among [org.webjars.npm:bootstrap-italia:jar:2.8.7 -> org.webjars.npm:video.js:jar:[8.0.4,9.0.0-0) -> org.webjars.npm:m3u8-parser:jar:[7.1.0,8.0.0-0) -> org.webjars.npm:videojs__vhs-utils:jar:[3.0.5,4), org.webjars.npm:bootstrap-italia:jar:2.8.7 -> org.webjars.npm:video.js:jar:[8.0.4,9.0.0-0) -> org.webjars.npm:mpd-parser:jar:[1.2.2,2.0.0-0) -> org.webjars.npm:videojs__vhs-utils:jar:[4.0.0,5.0.0-0), org.webjars.npm:bootstrap-italia:jar:2.8.7 -> org.webjars.npm:video.js:jar:[8.0.4,9.0.0-0) -> org.webjars.npm:videojs__vhs-utils:jar:[4.0.0,5.0.0-0), org.webjars.npm:bootstrap-italia:jar:2.8.7 -> org.webjars.npm:video.js:jar:[8.0.4,9.0.0-0) -> org.webjars.npm:videojs__http-streaming:jar:3.13.1 -> org.webjars.npm:videojs__vhs-utils:jar:4.0.0, org.webjars.npm:bootstrap-italia:jar:2.8.7 -> org.webjars.npm:video.js:jar:[8.0.4,9.0.0-0) -> org.webjars.npm:aes-decrypter:jar:[4.0.1,5.0.0-0) -> org.webjars.npm:videojs__vhs-utils:jar:[3.0.5,4)] -> [Help 1]

</exclusion>
<exclusion> <!-- exclude dependency, no versions available -->
<groupId>org.webjars.npm</groupId>
<artifactId>design-tokens-italia</artifactId>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How <artifactId>bootstrap-italia</artifactId> got promoted to Maven Central if its dependencies are not available ?!

Copy link
Contributor Author

@r1gm r1gm Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic ?

Output :

Failed to execute goal on project wicket-bootstrap-themes: Could not resolve dependencies for project
 de.agilecoders.wicket:wicket-bootstrap-themes:bundle:7.0.7-SNAPSHOT: Failed to collect dependencies at 
org.webjars.npm:bootstrap-italia:jar:2.8.7 -> org.webjars.npm:design-tokens-italia:jar:[1.1.1,2.0.0-0): No versions 
available for org.webjars.npm:design-tokens-italia:jar:[1.1.1,2.0.0-0) within specified range -> [Help 1]

Try to add new webjar from https://www.webjars.org/ but failed

Deploy Log

Starting Deploy
The metadata was missing a required field: /repository/url

issue report created
italia/design-tokens-italia#5

r1gm and others added 11 commits September 10, 2024 16:07
…1142)

Bumps [org.webjars.npm:eonasdan__tempus-dominus](https://github.com/Eonasdan/tempus-dominus) from 6.9.9 to 6.9.10.
- [Release notes](https://github.com/Eonasdan/tempus-dominus/releases)
- [Commits](Eonasdan/tempus-dominus@v6.9.9...v6.9.10)

---
updated-dependencies:
- dependency-name: org.webjars.npm:eonasdan__tempus-dominus
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.5.7 to 1.5.8.
- [Commits](qos-ch/logback@v_1.5.7...v_1.5.8)

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-classic
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `jetty.version` from 11.0.23 to 11.0.24.

Updates `org.eclipse.jetty:jetty-server` from 11.0.23 to 11.0.24

Updates `org.eclipse.jetty:jetty-webapp` from 11.0.23 to 11.0.24

Updates `org.eclipse.jetty:jetty-maven-plugin` from 11.0.23 to 11.0.24

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-server
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-webapp
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [org.webjars:jquery-ui](https://github.com/webjars/jquery-ui) from 1.13.3 to 1.14.0.
- [Commits](webjars/jquery-ui@jquery-ui-1.13.3...jquery-ui-1.14.0)

---
updated-dependencies:
- dependency-name: org.webjars:jquery-ui
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps org.apache.commons:commons-lang3 from 3.16.0 to 3.17.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-lang3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `maven-surefire-plugin.version` from 3.4.0 to 3.5.0.

Updates `org.apache.maven.plugins:maven-surefire-plugin` from 3.4.0 to 3.5.0
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.4.0...surefire-3.5.0)

Updates `org.apache.maven.surefire:surefire-junit47` from 3.4.0 to 3.5.0

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.maven.surefire:surefire-junit47
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….0 (#1135)

Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.8.0 to 3.10.0.
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.8.0...maven-javadoc-plugin-3.10.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-javadoc-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….0 (#1134)

Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.4.0...surefire-3.5.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-failsafe-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.12.0 to 5.13.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v5.12.0...v5.13.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g merged commit ae1ca66 into martin-g:wicket-10.x-bootstrap-5.x Sep 13, 2024
2 checks passed
@martin-g
Copy link
Owner

Thank you, @r1gm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants