fix(nordigen): nordea duplicate transactions

[martinohansen]

Nordea never sleeps, this is a fix for a duplicate transactions which is
caused by Nordea showing the same transaction twice with different
transaction IDs.

BREAKING CHANGE: Nordea users will have new import IDs generated which
causes duplicate transactions. To fix this set the YNAB_FROM_DATE value
to the day you start using this version.

[hpernu]

Couldn't fully check the changes but apparently things are only changed for Nordea Denmark. Is this correct?
I do not know whether the same change happened in other Nordic countries. I have not recently run this against Nordea Finland as I do not have any money nor transactions there currently(only stale empty accounts).

But BIC is different for Nordea Finland. So did operation stay exactly the same for all other banks except Nordea Denmark?

[martinohansen]

Couldn't fully check the changes but apparently things are only changed for Nordea Denmark. Is this correct?

I do not know whether the same change happened in other Nordic countries. I have not recently run this against Nordea Finland as I do not have any money nor transactions there currently(only stale empty accounts).

But BIC is different for Nordea Finland. So did operation stay exactly the same for all other banks except Nordea Denmark?

I did change it so every bank prefixed with NORDEA_ would get the new filtering (removing P transactions) but I also refactored it to use the default mapper which every bank should use.

Since you only have stall transactions it should be fine. I expect every Nordea bank to work the same, can we validate that assumption in any way using your bank?

[hpernu]

You mean stale transactions? I did not check closely enough how this behaves for older transactions but other than that I assume the Nordigen/Gocardless interface is able to go back in time quite far.

But I am not at all certain Nordea uses the same logic everywhere. There is a lot of Finnish and Swedish legacy in there and I think even the front ends were different until just a few years ago. I do think they have some of the old Cobol stuff still running deep down which may be country specific(even specific to old banks which have been integrated under Nordea). I have a friend working for them. Should I ask? :)

We could test it with my account but I don't have the Nordea integration on right now for any account as there is no need. Furthermore, this would require me to move money around for no practical usage. I also don't know how to detect this.

Anyway, before moving forward, we should define how to test exactly.

[martinohansen]

But I am not at all certain Nordea uses the same logic everywhere. There is a lot of Finnish and Swedish legacy in there and I think even the front ends were different until just a few years ago. I do think they have some of the old Cobol stuff still running deep down which may be country specific(even specific to old banks which have been integrated under Nordea). I have a friend working for them. Should I ask? :)

You might be right, if you have a direct line it would be great to know for sure!

We could test it with my account but I don't have the Nordea integration on right now for any account as there is no need. Furthermore, this would require me to move money around for no practical usage. I also don't know how to detect this.

Anyway, before moving forward, we should define how to test exactly.

I will change the logic back to only the danish affiliation is changed for now. I'm running with the dev version and will wait about a week to be sure it works before cutting a new version.