Simplified install and more infos in README #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marty1885
reviewed
Apr 8, 2024
| @@ -0,0 +1,7 @@ | |||
| export ARCH_NAME=grayskull | |||
| export TT_METAL_HOME=~/Desktop/devs/tt-metal/ | |||
There was a problem hiding this comment.
I'm not super sure this should be in the repository. Foremost, the path is for your specific setup and not everyone have tt-metal on their dekstop.
I'm more leaning towards removing this file for the sake of generality. What's your thought?
There was a problem hiding this comment.
Great point.
How about keeping the file, but changing the variable TT_METAL_HOME to
TT_METAL_HOME=/path/to/your/root/of/tt-metal/
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
setup_env.shto help with setup of the environment. Also added some extra details to the README.