Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check result is defined on fetchFinished correctly #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

goldensunliu
Copy link

@taion
Copy link
Member

taion commented Aug 31, 2015

Hmm - I think we'd want to do == null here instead. The intended behavior here is to treat null as a "not found" response.

Otherwise, the modules directory is actually a build artifact - you only need to change src; modules will get updated on build.

@goldensunliu
Copy link
Author

@taion you mean !_.isNull we need to check the not condition here. also I added to the modules so our fork of marty can work for now. how do I call build?

@goldensunliu
Copy link
Author

@taion can we merge this?

@taion
Copy link
Member

taion commented Sep 16, 2015

Please change the check to a null check. I'll merge and re-release after.

@goldensunliu
Copy link
Author

@taion all set

@taion
Copy link
Member

taion commented Sep 16, 2015

Any insight to the failures on Travis?

@goldensunliu
Copy link
Author

nothing obvious is jumping out at me hmmm

@taion
Copy link
Member

taion commented Sep 24, 2015

I took a quick look at the test failure - this is an actual bug in your code. You're hitting the fetchFinished branch on https://github.com/goldensunliu/marty-lib/blob/777b066cf4b1c3482e7541d840e67b6c55e94e02/src/store/storeFetch.js#L89, but not actually marking the fetch as finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application.RenderToString hangs when fetch result returns the value false.
2 participants