🆕 feat(MPagination): Added MiniVariant MiniVariantChange and MobileBr… #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capdiem
requested changes
Aug 1, 2024
| @@ -8,18 +8,29 @@ | |||
| <ul class="@_modifierBuilder.Add(Circle).Add(Disabled).AddTheme(IsDark, IndependentTheme)"> | |||
| @GenPaginationIcon(PaginationIconType.First) | |||
|
|
|||
| @foreach (var item in GetItems()) | |||
| @if (prevMiniVariant) | |||
There was a problem hiding this comment.
prevMiniVariant 这个记录内部的mini状态吗？是的话改为 _internalMiniVariant 明了一些。
Comment on lines
319
to
322
| if (IsDirtyParameter(nameof(MiniVariant))) | ||
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (IsDirtyParameter(nameof(MiniVariant))) | |
| { | |
| return; | |
| } |
用户没有给MiniVariant参数内部也是要去判断状态的。
|
|
||
| private bool CalMobileBreakpoint() => CalMobileBreakpoint(MasaBlazor, MobileBreakpoint); | ||
|
|
||
| private static bool CalMobileBreakpoint(MasaBlazor masaBlazor, OneOf<Breakpoints, double> mbpParam) |
There was a problem hiding this comment.
Suggested change
| private static bool CalMobileBreakpoint(MasaBlazor masaBlazor, OneOf<Breakpoints, double> mbpParam) | |
| private static bool IsMiniVaraint(MasaBlazor masaBlazor, OneOf<Breakpoints, double> mobileBreakpoint) |
非必要不要用缩写。
| return; | ||
| } | ||
|
|
||
| var isM = CalMobileBreakpoint(); |
There was a problem hiding this comment.
Suggested change
| var isM = CalMobileBreakpoint(); | |
| var isMiniVaraint = CalMobileBreakpoint(); |
| protected override void OnInitialized() | ||
| { | ||
| MasaBlazor.WindowSizeChanged -= MasaBlazor_WindowSizeChanged; | ||
| MasaBlazor.WindowSizeChanged += MasaBlazor_WindowSizeChanged; |
| { | ||
| MasaBlazor.WindowSizeChanged -= MasaBlazor_WindowSizeChanged; | ||
| MasaBlazor.WindowSizeChanged += MasaBlazor_WindowSizeChanged; | ||
| } |
capdiem
requested changes
Aug 1, 2024
Co-authored-by: capdiem <capdiem@live.com>
Co-authored-by: capdiem <capdiem@live.com>
Co-authored-by: capdiem <capdiem@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPagination
MiniVariantMiniVariantChangeMobileBreakpointMiniVariantis not set, it will automatically switch based on theMasaBlazor.Breakpoint