New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods getMaxTimepoint() and getMinTimepoint() to TreeUtils #274

Merged

tinevez merged 1 commit into mastodon-sc:dev from stefanhahmann:add_max_min_timepoint_methods

Jan 15, 2024

Collaborator

stefanhahmann commented Jan 10, 2024 •

edited

Loading

These methods exist now in 2 plugins and by moving them to the core one could reduce code duplication
cf. https://github.com/mastodon-sc/mastodon-tomancak/blob/1c2c684cd209bc8db7d75e0183674cf010434a2e/src/main/java/org/mastodon/mamut/tomancak/merging/Dataset.java#L63
cf. https://github.com/mastodon-sc/mastodon-deep-lineage/blob/master/src/main/java/org/mastodon/mamut/util/LineageTreeUtils.java#L130


          Add methods getMaxTimepoint() and getMinTimepoint() to TreeUtils

69e3efd

* These methods exist now in 2 plugins and by moving them to the core one could reduce code duplication
* cf. https://github.com/mastodon-sc/mastodon-tomancak/pull/53/files
* cf. https://github.com/mastodon-sc/mastodon-deep-lineage/blob/master/src/main/java/org/mastodon/mamut/util/LineageTreeUtils.java#L130

stefanhahmann requested a review from tinevez

January 10, 2024 11:47

stefanhahmann mentioned this pull request

Fix "File > Merge Two Projects..." mastodon-sc/mastodon-tomancak#53

Merged

tinevez merged commit dc0a103 into mastodon-sc:dev

1 check passed

stefanhahmann deleted the add_max_min_timepoint_methods branch

February 26, 2024 12:51

stefanhahmann self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet