Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring an envFile for the mypy environment #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danlamanna
Copy link

Fixes #25, see #25 (comment) for an example to reproduce the issue of needing environment variables. This is most commonly necessary when using the django-stubs plugin because a full fledged django environment is necessary to execute type checking. Warning: I don't really write typescript, I just sort of threw this together and it appears to work for me.

@matangover
Copy link
Owner

Looks great! Thanks

@danlamanna
Copy link
Author

Hey, would you mind merging this and cutting a release?

@matangover
Copy link
Owner

Hope to get to it in the next few days.
Btw why did you choose env file as opposed to setting it directly in the settings?

@danlamanna
Copy link
Author

Btw why did you choose env file as opposed to setting it directly in the settings?

I'm not sure what you mean, why use an env file instead of setting key/value pairs in the settings? I wanted to mimic how vscode-python does things as much as possible (see https://github.com/microsoft/vscode-python/blob/5e5a7ce7b6b516d4919d72a27dc18c9ec3992861/src/client/common/variables/environment.ts#L125).

mstmb-alan added a commit to alan-eu/mypy-vscode-plus that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any way to pass in ENV variables?
2 participants