Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listo el compilador #41

Open
wants to merge 204 commits into
base: master
Choose a base branch
from
Open

Listo el compilador #41

wants to merge 204 commits into from

Conversation

cwjki
Copy link

@cwjki cwjki commented Feb 25, 2022

No description provided.

cwjki and others added 30 commits March 1, 2021 15:17
@cwjki
agregando mi nombre y usuario jki
aaf658c
@livi98
Datos de Pin
b98c481
@cwjki
Peña
dec819f
@livi98
test
a61d547
@livi98
esto es una prueba
a10d4bb
@cwjki
otra prueba
57b45a5
@cwjki
Merge branch 'master' of https://github.com/Pin-y-Pon/cool-compiler-2021
6ecbeca
@cwjki
test
0a70bd2
@cwjki
no funciono lo que queriamos probar
dda94c3
@cwjki
lexer.py init
f507eaa
@cwjki
tokens and reserved lexer
a9af1fa
@cwjki
working on lexer.py
530b10e
@cwjki
workin on lexer.py
90a4923
@cwjki
comments and strings in lexer
88865ff
@cwjki
lexer finished, i hope :)
b02c985
@cwjki
solve conflict in team.yml
01bf9b5
@cwjki
starting ast.py
24d2143
@cwjki
adding some nodes to ast.py
9db81e5
@cwjki
almost finish the ast
c897722
@cwjki
ast nodes done
9a8e430
@cwjki
starting the parser
6a60ca2
@cwjki
working on the parser
4ee8e3b
@cwjki
working on parser
bd57ebf
@cwjki
adding lines and columns in parser
6d5450f
@cwjki
not finished expr parser
c1f6b8b
@cwjki
parser finished, hope :)
4a2131f
@cwjki
before testing lexer and parser
039de67
@cwjki
fixing some names and imports
6fb5b21
@cwjki
fixing some typos in parser.py
7016996
@cwjki
adding visitor .py
1695462
livi98 and others added 25 commits February 24, 2022 01:23
@livi98
testing fib
c2a4abc
@livi98
cahnging not and xor
6bc3200
@livi98
changing again xor and neg
e329396
@cwjki
fixing a bug in get_attributte
425bb5b
@cwjki
7/17 codegen pass
c19f835
@cwjki
trying to fix primes.cl test
36a2e9e
@cwjki
having trouble with the parent of built in
b8036be
@cwjki
again
44aaaca
@cwjki
checking parent of built in
a55433d
@cwjki
rechecking parent of built in
a77ffe1
@cwjki
problem solve
cecd267
@cwjki
testing void
b97e669
@cwjki
changing neg y xor cil
035eab3
@cwjki
handlign void types
4c2d399
@cwjki
fixing a bug in parents
bda9e37
@cwjki
no funciono lo anterior
885ab89
@cwjki
fixing a typo with self type
6f2e89a
@cwjki
fixing the case graph
32bef4f
@cwjki
have a problem printing string
5cc9ff3
@cwjki
retest
9667b1c
@cwjki
printing a \t de mas
1782916
@cwjki
fix the f /t problem, hope all test pass
65fd701
@cwjki
ALL TEST PASSED, deleting some comments and useless imports
45da2b0
@cwjki
deleting unneccesary files
6baf39e
@livi98
adding report.pdf
129685f
@jpconsuegra jpconsuegra self-requested a review March 8, 2022 12:23
@jpconsuegra jpconsuegra self-assigned this Mar 8, 2022
@jpconsuegra
Copy link
Collaborator

jpconsuegra commented Mar 8, 2022 •
edited
Loading

Evaluación

  • Olivia Gonzalez Peña
  • Juan Carlos Casteleiro Wong

Requisitos mínimos (3)

  • El proyecto pasa todos los tests
  • El informe existe y explica el uso del compilador y la arquitectura básica

Requisitos intermedios (4)

  • Se implementaron las fases de chequeo semántico de forma separada y utilizando patrones adecuados
  • La arquitectura del compilador está organizada de forma coherente y mantenible

Requisitos extra (5)

  • Se implementaron las fases de generación de código intermedio y código objeto con patrones adecuados
  • Se resolvieron los problemas de representación de objetos en memoria e invocación de métodos virtuales de forma eficiente
  • Se resolvieron los problemas de boxing/unboxing de forma eficiente
  • Se resuelve el case eficientemente.

Comentarios

  • No encontré en el informe cómo resuelven los problemas de boxing/unboxing.
  • No encontré en el informe cómo resuelven el case en runtime.

Nota final

Evaluación Nota
Final 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpconsuegra jpconsuegra Awaiting requested review from jpconsuegra

Assignees

@jpconsuegra jpconsuegra

Labels
Aprobado Final Finalizado
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwjki @jpconsuegra @livi98