made tests for implementations and added files #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliia-ponomarenko
suggested changes
Sep 20, 2023
| @@ -0,0 +1,28 @@ | |||
| package model; | |||
There was a problem hiding this comment.
Why is the model package placed here?
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class FileWriterServiceImplTest { | ||
|
|
| assertThrows(RuntimeException.class, () -> fruitService.processFruitLines(data)); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
which difference between this test and input_InvalidData_NotOk
| ActivityType.PURCHASE, new PurchaseOperationsHandler(), | ||
| ActivityType.RETURN, new ReturnOperationsHandler() | ||
| )); | ||
|
|
| new FruitTransaction(ActivityType.BALANCE, "apple", 100), | ||
| new FruitTransaction(ActivityType.SUPPLY, "banana", 100) | ||
| ); | ||
| assertDoesNotThrow(() -> processService.process(data)); |
There was a problem hiding this comment.
you should check data in storage and add more test cases, for instance, purchase when fruits are not enough, other operations, etc.
Comment on lines
38
to
42
| Storage.getStorage().put("banana", 100); | ||
| Storage.getStorage().put("apple", 100); | ||
| String expected = "fruit,quantity" + System.lineSeparator() | ||
| + "banana,100" + System.lineSeparator() | ||
| + "apple,100"; |
| import org.junit.jupiter.api.BeforeAll; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class FileWriterServiceImplTest { |
There was a problem hiding this comment.
you also can add a method that reads the file and checks the data that was written.
Elena-Bruyako
suggested changes
Sep 25, 2023
| new FruitTransaction(ActivityType.BALANCE, "apple", 100), | ||
| new FruitTransaction(ActivityType.SUPPLY, "banana", 100) | ||
| ); | ||
| assertDoesNotThrow(() -> processService.process(data)); |
| import org.junit.jupiter.api.BeforeAll; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class FileWriterServiceImplTest { |
Andriy-dz
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.