created tests for FruitShop #785

validatorr · 2023-09-19T10:22:41Z

No description provided.

pavlov-n

Good job. Global comment: names for test.methods + i'm not sure about initialisation in beforeAll, but if you think it's correct, leave it for mentors

pavlov-n · 2023-09-19T11:33:43Z

src/test/java/core/basesyntax/service/OperationServiceTest.java

+        String expected = "fruit,quantity\n"
+                + "banana,152\r\n"
+                + "apple,90\r\n";
+        List<String> inputData = new ReadServiceImpl().readInputData(INPUT_PATH);
+        List<FruitTransaction> parseData = new ParseServiceImpl().parseInputData(inputData);
+        operationService = new OperationService(operationStrategy);
+        operationService.processOperation(parseData);
+        String actual = new ReportServiceImpl().createReport();


Unit testing is isolated testing. Ensure that you test your services and their independently. I think you are using a lot of classes here

pavlov-n · 2023-09-19T11:39:22Z

src/test/java/core/basesyntax/service/impl/ParseServiceImplTest.java

+        emptyList = new ArrayList<>();
+        inputData = new ArrayList<>(Arrays.asList(
+                "type,fruit,quantity",
+                "b,banana,100",
+                "s,banana,100",
+                "p,banana,100",
+                "r,banana,100"));
+        parseData = parseService.parseInputData(inputData);


I think you need to use it in test methods.

pavlov-n · 2023-09-19T11:42:45Z

src/main/java/core/basesyntax/service/impl/ReportServiceImpl.java

+import java.util.Map;
+
+public class ReportServiceImpl implements ReportService {
+    private static final String FIRST_ROW = "fruit,quantity\n";


use System.lineSeparator(), not \n.

pavlov-n · 2023-09-19T11:47:28Z

src/test/java/core/basesyntax/service/impl/ReportServiceImplTest.java

+        String expected = FIRST_ROW
+                + "banana,20\r\n"
+                + "apple,15\r\n";


use System.lineSeparator()

Andriy-dz

Good Job! Lets improve your solution)

Andriy-dz · 2023-09-20T14:05:23Z

src/test/java/core/basesyntax/service/OperationServiceTest.java

+                + System.lineSeparator();
+        List<String> inputData = new ReadServiceImpl().readInputData(INPUT_PATH);
+        List<FruitTransaction> parseData = new ParseServiceImpl().parseInputData(inputData);
+        operationService = new OperationService(operationStrategy);


u must initializate it in BeforeAll method

Andriy-dz · 2023-09-20T14:06:46Z

src/test/java/core/basesyntax/service/OperationServiceTest.java

+        List<FruitTransaction> parseData = new ParseServiceImpl().parseInputData(inputData);
+        operationService = new OperationService(operationStrategy);
+        operationService.processOperation(parseData);
+        String actual = new ReportServiceImpl().createReport();


u must test here only operationService. Dont use another services

Andriy-dz · 2023-09-20T14:08:13Z

src/test/java/core/basesyntax/service/impl/ParseServiceImplTest.java

+    private static final int BALANCE_INDEX = 0;
+    private static final int SUPPLY_INDEX = 1;
+    private static final int PURCHASE_INDEX = 2;
+    private static final int RETURN_INDEX = 3;
+    private static final String FRUIT = "banana";
+    private static final int QUANTITY = 100;
+    private static ParseService parseService;
+    private static List<String> inputData;
+    private static List<String> emptyList;
+    private static List<FruitTransaction> parseData;


Suggested change

private static final int BALANCE_INDEX = 0;

private static final int SUPPLY_INDEX = 1;

private static final int PURCHASE_INDEX = 2;

private static final int RETURN_INDEX = 3;

private static final String FRUIT = "banana";

private static final int QUANTITY = 100;

private static ParseService parseService;

private static List<String> inputData;

private static List<String> emptyList;

private static List<FruitTransaction> parseData;

private static ParseService parseService;

you don't really need these variables. Create them and use them in the test methods you need. Likewise in other test classes

Andriy-dz · 2023-09-20T14:09:02Z

src/test/java/core/basesyntax/service/impl/ParseServiceImplTest.java

+    }
+
+    @Test
+    void correctParseData_Ok() {


which method is being tested here - not an informative method name. The same in other tests

Andriy-dz · 2023-09-20T14:12:21Z

src/test/java/core/basesyntax/service/impl/ParseServiceImplTest.java

+                "p,banana,100",
+                "r,banana,100"));
+        parseData = parseService.parseInputData(inputData);
+        FruitTransaction balanceTransaction = parseData.get(BALANCE_INDEX);


here you can create a list that you expect to return as a result of executing the method and compare

Andriy-dz · 2023-09-20T14:13:10Z

src/test/java/core/basesyntax/service/impl/ReportServiceImplTest.java

+        String expected = FIRST_ROW
+                + "banana,20"
+                + System.lineSeparator()
+                + "apple,15"
+                + System.lineSeparator();


lets use StrringBuilder

Andriy-dz · 2023-09-20T14:14:12Z

src/test/java/core/basesyntax/service/impl/WriteServiceImplTest.java

+class WriteServiceImplTest {
+    private static final String OUTPUT_PATH = "src/main/java/resources/output.csv";
+    private static final String REPORT = "fruit,quantity\n"
+            + "banana,152\r\n"


why not System.lineSeparator()?

Andriy-dz · 2023-09-20T14:15:07Z

src/test/java/core/basesyntax/service/impl/WriteServiceImplTest.java

+
+    @Test
+    void writeReport_Ok() {
+        String actual = writerService.writeToFile(OUTPUT_PATH, REPORT);


here it is better to read the result from the corresponding file and compare the data

Andriy-dz · 2023-09-20T14:15:50Z

src/test/java/core/basesyntax/strategy/OperationStrategyTest.java

+
+    @Test
+    void getSuppleHandler_Ok() {
+        operationHandler = new SupplyOperationHandler();


lets initializate it in BeforeAll method

Elena-Bruyako · 2023-09-25T06:28:08Z

src/test/java/core/basesyntax/service/ReportServiceImplTest.java

+import org.junit.jupiter.api.Test;
+
+class ReportServiceImplTest {
+    //private static final String FIRST_ROW = "fruit,quantity" + System.lineSeparator();


Don't forget to remove commented code

created tests for FruitShop

7f3b8c4

pavlov-n suggested changes Sep 19, 2023

View reviewed changes

validatorr added 3 commits September 19, 2023 16:21

added fixes

1dc1023

added fixes

13a07d1

minor fix

d317b52

Andriy-dz suggested changes Sep 20, 2023

View reviewed changes

added fixes

938cadd

validatorr requested a review from Andriy-dz September 24, 2023 13:12

Elena-Bruyako approved these changes Sep 25, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

created tests for FruitShop #785

created tests for FruitShop #785

validatorr commented Sep 19, 2023

pavlov-n left a comment

pavlov-n Sep 19, 2023

pavlov-n Sep 19, 2023

pavlov-n Sep 19, 2023

pavlov-n Sep 19, 2023

Andriy-dz left a comment

Andriy-dz Sep 20, 2023

Andriy-dz Sep 20, 2023

Andriy-dz Sep 20, 2023

Andriy-dz Sep 20, 2023

Andriy-dz Sep 20, 2023

Andriy-dz Sep 20, 2023

Andriy-dz Sep 20, 2023

Andriy-dz Sep 20, 2023

Andriy-dz Sep 20, 2023

Elena-Bruyako Sep 25, 2023

created tests for FruitShop #785

Are you sure you want to change the base?

created tests for FruitShop #785

Conversation

validatorr commented Sep 19, 2023

pavlov-n left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Andriy-dz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment