add tests to fruitshop solution #787
Conversation
| void addProductToEmptyStorage_Ok() { | ||
| StorageDao storageDao = new StorageDaoImpl(); | ||
| storageDao.add(banana, quantity); | ||
| Integer expected = 50; |
There was a problem hiding this comment.
maybe you should use constants for all the numbers, so code could look cleaner
There was a problem hiding this comment.
you don't need to use constants in tests
| static void setUp() { | ||
| apple = new Fruit("apple"); | ||
| supplyOperationHandler = new SupplyOperationHandler(); | ||
| Storage.storage.clear(); |
There was a problem hiding this comment.
Should you use Storage.storage.clear() here if you use it in @AfterEach?
| private final Fruit banana = new Fruit("banana"); | ||
| private final Fruit apple = new Fruit("apple"); | ||
| private final int quantity = 50; |
| void addProductToEmptyStorage_Ok() { | ||
| StorageDao storageDao = new StorageDaoImpl(); | ||
| storageDao.add(banana, quantity); | ||
| Integer expected = 50; |
There was a problem hiding this comment.
you don't need to use constants in tests
|
|
||
| @Test | ||
| void addProductToEmptyStorage_Ok() { | ||
| StorageDao storageDao = new StorageDaoImpl(); |
There was a problem hiding this comment.
make it class field and use in all test methods
| } | ||
|
|
||
| @Test | ||
| void subtractProduct_Ok() { |
There was a problem hiding this comment.
wrong name. which of the methods are you testing. Same in another tests
| private static Fruit apple; | ||
| private static OperationHandler balanceOperationHandler; | ||
| private static FruitTransaction fruitTransaction; |
There was a problem hiding this comment.
| private static Fruit apple; | |
| private static OperationHandler balanceOperationHandler; | |
| private static FruitTransaction fruitTransaction; | |
| private static OperationHandler balanceOperationHandler; |
u dont need this as class field
| @BeforeAll | ||
| static void setUp() { | ||
| apple = new Fruit("apple"); | ||
| balanceOperationHandler = new BalanceOperationHandler(); |
There was a problem hiding this comment.
StorageDao in your implementations must be initialized in the constructor. Same everywhere
| static void setUp() { | ||
| apple = new Fruit("apple"); | ||
| supplyOperationHandler = new SupplyOperationHandler(); | ||
| Storage.storage.clear(); |
| final int initialBananaBalance = Storage.storage.get(banana); | ||
| final int initialAppleBalance = Storage.storage.get(apple); | ||
| int quantity = 25; | ||
| FruitTransaction transaction1 = new FruitTransaction(); |
There was a problem hiding this comment.
StorageDao in your implementations must be initialized in the constructor. Same in another cases
| transactions.add(transaction1); | ||
| transactions.add(transaction2); | ||
|
|
||
| operationProcessorService.process(transactions, operationStrategy); |
There was a problem hiding this comment.
OperationStrategy must by class field. U dont need set it as parameter
No description provided.