added tests for Fruit Shop #790

dmytrocherepov · 2023-09-19T21:51:00Z

No description provided.

SalnikovMarkiian

First, not all checks passed.
The decision is very good!!! :) And if there is no desire to suffer - my comments are optional for you.
fix styleChecks (maybe a problem with the number of tests) or some small, isolated bugs

SalnikovMarkiian · 2023-09-20T08:53:58Z

src/test/java/core/basesyntax/handlers/BalanceOperationHandlerTest.java

+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+
+public class BalanceOperationHandlerTest {


what happens, when Quantity < 0 or new FruintTransaction has null as fruit name or null as operation type?

SalnikovMarkiian · 2023-09-20T08:56:08Z

src/test/java/core/basesyntax/handlers/PurchaseOperationHandlerTest.java

+class PurchaseOperationHandlerTest {
+    private static PurchaseOperationHandler purchaseOperationHandler;
+
+    @BeforeAll


I would use here @beforeeach for init
I'm not sure if it will change much, so it`s up to u

SalnikovMarkiian · 2023-09-20T09:01:24Z

src/test/java/core/basesyntax/handlers/PurchaseOperationHandlerTest.java

+        int fruitsInStorage = Storage.STORAGE.get("banana");
+        assertEquals(30, fruitsInStorage);
+    }
+


I`d like to add test for negative quantity and null transaction (optional for u)

SalnikovMarkiian · 2023-09-20T09:03:24Z

src/test/java/core/basesyntax/handlers/ReturnOperationHandlerTest.java

+class ReturnOperationHandlerTest {
+    private static ReturnOperationHandler returnOperationHandler;
+
+    @BeforeAll


the same (BeforeEach) but we can wait what mentor says)

SalnikovMarkiian · 2023-09-20T09:05:36Z

src/test/java/core/basesyntax/handlers/ReturnOperationHandlerTest.java

+    void tearDown() {
+        Storage.STORAGE.clear();
+    }
+


we expect only a good result, mb will it be better to test notOk cases additionally?

SalnikovMarkiian · 2023-09-20T09:08:12Z

src/test/java/core/basesyntax/handlers/SupplyOperationHandlerTest.java

+    void tearDown() {
+        Storage.STORAGE.clear();
+    }
+


the same about notOk cases

SalnikovMarkiian · 2023-09-20T09:12:29Z

src/test/java/core/basesyntax/services/FileReaderServiceTest.java

+class FileReaderServiceTest {
+    private static FileReaderService fileReaderService;
+    private static final String VALID_FILE_PATH = "src/test/java/resources/test.csv";
+    private static final String INVALID_FILE_PATH = "src/test/java/resources/InvalidTest.csv";


Can we consider this as a wrong path, because there is a non-existent file, not a directory.
Perhaps this is a topic for conversation)

SalnikovMarkiian · 2023-09-20T09:14:46Z

src/test/java/core/basesyntax/services/FileWriterServiceTest.java

+    static void beforeAll() {
+        fileWriterService = new FileWriterServiceImpl();
+    }
+


What happens if our report is null ?)

SalnikovMarkiian · 2023-09-20T11:43:59Z

pom.xml

@@ -87,7 +87,7 @@
                                        <limit>
                                            <counter>LINE</counter>
                                            <value>COVEREDRATIO</value>
-                                            <minimum>0.8</minimum>
+                                            <minimum>0.8 </minimum>


why u changed this ?

Andriy-dz

Good solution! Let's improve it)

Andriy-dz · 2023-09-22T14:24:02Z

src/test/java/core/basesyntax/handlers/BalanceOperationHandlerTest.java

+    }
+
+    @Test
+    void calculateOperation_ok() {


not informative name for method

Andriy-dz · 2023-09-22T14:25:13Z

src/test/java/core/basesyntax/handlers/BalanceOperationHandlerTest.java

+        FruitTransaction bananaTransaction = new FruitTransaction(
+                FruitTransaction.Operation.BALANCE, "banana", -100
+        );
+        assertThrows(RuntimeException.class,


why RuntimeException?

Andriy-dz · 2023-09-22T14:25:55Z

src/test/java/core/basesyntax/handlers/PurchaseOperationHandlerTest.java

+    }
+
+    @Test
+    void processPurchaseOperation_ok() {


not informative name for method

Andriy-dz · 2023-09-22T14:26:49Z

src/test/java/core/basesyntax/handlers/PurchaseOperationHandlerTest.java

+        FruitTransaction fruitTransaction = new FruitTransaction(
+                FruitTransaction.Operation.PURCHASE, "banana", -100
+        );
+        assertThrows(RuntimeException.class,


better to use InvalidDataException

Andriy-dz · 2023-09-22T14:26:55Z

src/test/java/core/basesyntax/handlers/PurchaseOperationHandlerTest.java

+        FruitTransaction fruitTransaction = new FruitTransaction(
+                FruitTransaction.Operation.PURCHASE, "banana", 70
+        );
+        assertThrows(RuntimeException.class,


Andriy-dz · 2023-09-22T14:27:30Z

src/test/java/core/basesyntax/handlers/ReturnOperationHandlerTest.java

+    }
+
+    @Test
+    void processReturnOperation_ok() {


not informative name for method

Andriy-dz · 2023-09-22T14:27:45Z

src/test/java/core/basesyntax/handlers/SupplyOperationHandlerTest.java

+    }
+
+    @Test
+    void processSupply_ok() {


not informative name for method

Andriy-dz · 2023-09-22T14:27:53Z

src/test/java/core/basesyntax/handlers/ReturnOperationHandlerTest.java

+        FruitTransaction bananaTransaction = new FruitTransaction(
+                FruitTransaction.Operation.BALANCE, "banana", -100
+        );
+        assertThrows(RuntimeException.class,


Andriy-dz · 2023-09-22T14:27:59Z

src/test/java/core/basesyntax/handlers/SupplyOperationHandlerTest.java

+        FruitTransaction bananaTransaction = new FruitTransaction(
+                FruitTransaction.Operation.BALANCE, "banana", -100
+        );
+        assertThrows(RuntimeException.class,


Andriy-dz · 2023-09-26T09:44:12Z

src/main/java/core/basesyntax/handlers/ReturnOperationHandler.java

+        if (transaction.getQuantity() < 0) {
+            throw new InvalidDataException("Negative quantity");
+        } else if (transaction.getFruit() == null) {
+            throw new NullPointerException("Invalid fruit type");


Suggested change

throw new NullPointerException("Invalid fruit type");

throw new InvalidDataException("Invalid fruit type");

same everywhere

added tests for Fruit Shop

4080a89

SalnikovMarkiian suggested changes Sep 20, 2023

View reviewed changes

dmytrocherepov added 2 commits September 20, 2023 12:40

added fixes

69c1c5a

added tests for task

caea4f8

dmytrocherepov requested a review from SalnikovMarkiian September 20, 2023 10:45

added fixes

22d1097

SalnikovMarkiian approved these changes Sep 20, 2023

View reviewed changes

Andriy-dz suggested changes Sep 22, 2023

View reviewed changes

dmytrocherepov added 2 commits September 25, 2023 12:43

added fixes after review

9872b22

added fixes

a91d0e7

dmytrocherepov requested a review from Andriy-dz September 25, 2023 09:53

Andriy-dz approved these changes Sep 26, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added tests for Fruit Shop #790

added tests for Fruit Shop #790

dmytrocherepov commented Sep 19, 2023

SalnikovMarkiian left a comment

SalnikovMarkiian Sep 20, 2023

SalnikovMarkiian Sep 20, 2023

SalnikovMarkiian Sep 20, 2023

SalnikovMarkiian Sep 20, 2023

SalnikovMarkiian Sep 20, 2023 •

edited

Loading

SalnikovMarkiian Sep 20, 2023

SalnikovMarkiian Sep 20, 2023

SalnikovMarkiian Sep 20, 2023

SalnikovMarkiian Sep 20, 2023

Andriy-dz left a comment

Andriy-dz Sep 22, 2023

Andriy-dz Sep 22, 2023

Andriy-dz Sep 22, 2023

Andriy-dz Sep 22, 2023

Andriy-dz Sep 22, 2023

Andriy-dz Sep 22, 2023

Andriy-dz Sep 22, 2023

Andriy-dz Sep 22, 2023

Andriy-dz Sep 22, 2023

Andriy-dz Sep 26, 2023

Andriy-dz Sep 26, 2023

	throw new NullPointerException("Invalid fruit type");
	throw new InvalidDataException("Invalid fruit type");

added tests for Fruit Shop #790

Are you sure you want to change the base?

added tests for Fruit Shop #790

Conversation

dmytrocherepov commented Sep 19, 2023

SalnikovMarkiian left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SalnikovMarkiian Sep 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Andriy-dz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SalnikovMarkiian Sep 20, 2023 •

edited

Loading