I have written all the tests #791
Conversation
| void readFromFile_pathToFile_ok() { | ||
| List<String> expectedLines = List.of( | ||
| "b,banana,20", | ||
| "b,apple,100", | ||
| "s,banana,100", | ||
| "p,banana,13", | ||
| "r,apple,10", | ||
| "p,apple,20", | ||
| "p,banana,5", | ||
| "s,banana,50" | ||
| ); | ||
| List<String> lines = readerService.readFromFile(PATH_TO_FILE); | ||
| assertEquals(expectedLines, lines); | ||
| } |
There was a problem hiding this comment.
I guess it's better to use words "expected"/"actual" intead of "expectedLines"/"lines", or at least "expectedLines"/"actualLines".
There was a problem hiding this comment.
LOL, I renamed all variables beside except where it says
| } | ||
|
|
||
| @Test | ||
| void parse_wrongAmount_notOk() { |
There was a problem hiding this comment.
Maybe it's better to call method "invalidAmount" because you have used word "Invalid" in previous and next methods.
| List<String> lines = List.of("b,apple,100", "s,apple,20", | ||
| "s,apple,30", "p,apple,ten"); |
There was a problem hiding this comment.
There was a problem hiding this comment.
I catch NumberFormatException in my ParseServiceImpl when I parse String to Integer
| + "banana,10" + System.lineSeparator() | ||
| + "apple,40"; | ||
| writeService.writeToFile(PATH_TO_FILE, report); | ||
| String actualReport = readFromFile(); |
There was a problem hiding this comment.
I guess if you test "writePathToFile" method you should not use another methods from your code (You shouldn't use readFromFile())
There was a problem hiding this comment.
It`s for the KISS principle. I created a new method here outside of my other classes. Maybe, you are right, but I'll leave it like this for now.
| private static Operation balanceOperation; | ||
|
|
||
| @BeforeAll | ||
| static void setUp() { |
There was a problem hiding this comment.
It seems that setUp() method uses with @beforeeach annotation. And for @BeforeAll it's better to use beforeAll()
| void readFromFile_pathToFile_ok() { | ||
| List<String> expectedLines = List.of( | ||
| "b,banana,20", | ||
| "b,apple,100", | ||
| "s,banana,100", | ||
| "p,banana,13", | ||
| "r,apple,10", | ||
| "p,apple,20", | ||
| "p,banana,5", | ||
| "s,banana,50" | ||
| ); | ||
| List<String> lines = readerService.readFromFile(PATH_TO_FILE); | ||
| assertEquals(expectedLines, lines); | ||
| } |
| } | ||
|
|
||
| @Test | ||
| void readFromFile_pathToFile_ok() { |
There was a problem hiding this comment.
| void readFromFile_pathToFile_ok() { | |
| void readFromFile_validPathToFile_ok() { |
| String expected = "fruit,quantity" + System.lineSeparator() | ||
| + "banana,10" + System.lineSeparator() | ||
| + "apple,40"; | ||
| assertEquals(expected, reportCreatorService.createReport()); |
| assertEquals(expected, actual); | ||
| } | ||
|
|
||
| private static String readFromFile() { |
| } | ||
|
|
||
| @Test | ||
| void writeToFile_writePathToFile_ok() { |
| } | ||
|
|
||
| @Test | ||
| public void performOperation_enoughFruits_notOk() { |
No description provided.