My implementation of FruitShopTest. #796
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andriy-dz
suggested changes
Sep 25, 2023
| private static final String PATH = "src/test/resources/transactions.csv"; | ||
| private static final String WRONG_PATH = "src/test/resources/newTransactions.csv"; | ||
| private static FileReaderService fileReaderService; | ||
| private static List<String> expectedList; |
There was a problem hiding this comment.
u can create and use it in test method
Comment on lines
+16
to
+18
| private static final String EXPECTED_REPORT = "fruit,quantity" + System.lineSeparator() | ||
| + "banana,110" + System.lineSeparator() | ||
| + "apple,160" + System.lineSeparator(); |
There was a problem hiding this comment.
same. Don't use constant. Better to create and use variables in test methods
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class OperationProcessTest { | ||
| private static final FruitDao fruitDao = new FruitDaoImpl(); |
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class ReportServiceTest { | ||
| private static final String EXPECTED_RESULT = "fruit,quantity" + System.lineSeparator() |
| reportService = new ReportServiceImpl(); | ||
| } | ||
|
|
||
| @BeforeEach |
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class BalanceHandlerTest { | ||
| private static final FruitDao fruitDao = new FruitDaoImpl(); |
| class OperationHandlerStrategyTest { | ||
| private static OperationHandlerStrategy operationHandlerStrategy; | ||
| private static Map<FruitTransaction.Operation, OperationHandler> handlerMap = new HashMap<>(); | ||
| private static OperationHandler expected; |
| Storage.STORAGE.put("banana", 100); | ||
| operationHandler.execute("banana", 40); | ||
| assertEquals(140, Storage.STORAGE.get("banana")); | ||
| } |
There was a problem hiding this comment.
what will happen if the data is negative?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.