created first version fruit-shop-tests, there is a problem with coverage #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonyasapsan
approved these changes
Sep 25, 2023
Andriy-dz
suggested changes
Sep 26, 2023
| void createReport_createdCorrectReport_Ok() { | ||
| Storage.STORAGE.put("banana", 152); | ||
| Storage.STORAGE.put("apple", 90); | ||
| String expected = "fruit,quantity" + System.lineSeparator() |
| } | ||
|
|
||
| @Test | ||
| void processing_successProcessedSupllyOperation_Ok() { |
There was a problem hiding this comment.
in this case, you don't need to test in this style. I think that one test with different types of operations is enough for you and expect that no error occurs
| @Test | ||
| void writeToFile_correctWrittenReport_Ok() { | ||
| String pathToFile = "src/main/resources/report.csv"; | ||
| String expected = "fruit,quantity" + System.lineSeparator() |
There was a problem hiding this comment.
let's use StringBuilder. Same in other cases
Andriy-dz
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.