add solution1 #799
Open
add solution1 #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanYuzviak
suggested changes
Sep 24, 2023
| @@ -0,0 +1,4 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| class MainTest { | |||
| private ReaderService fileReaderService = new FileReaderServiceImpl(); | ||
|
|
||
| @Test | ||
| void readFromNonExistingDirectory_notOk() { |
There was a problem hiding this comment.
In method name there is not the name of method
| } | ||
|
|
||
| @Test | ||
| void readFromExistingDirectory_Ok() { |
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class ReportCreatorServiceImplTest { | ||
| private static ReportCreatorService reportCreatorService; |
There was a problem hiding this comment.
I think you can add keyword final here
Andriy-dz
suggested changes
Oct 5, 2023
| @Test | ||
| void convertData_notNumericQuantity_notOk() { | ||
| List<String> data = List.of("b,banana,10", "b,apple,10", "s,banana,2a0"); | ||
| assertThrows(RuntimeException.class, |
There was a problem hiding this comment.
where in your code u throw RuntimeException?
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class BalanceOperationTest { | ||
| private final OperationService balanceOperation = new BalanceOperation(); |
There was a problem hiding this comment.
lets initializate it in BeforeAll. Same in other cases
| balanceOperation.doOperation(appleTransaction); | ||
| int secondAppleActual = Storage.getStorage().get("apple"); | ||
| assertEquals(120, secondAppleActual); | ||
| } |
There was a problem hiding this comment.
what will happen if you send a negative value or null here. Same in other cases
Andriy-dz
approved these changes
Oct 11, 2023
| @Test | ||
| void convertData_notNumericQuantity_notOk() { | ||
| List<String> data = List.of("b,banana,10", "b,apple,10", "s,banana,2a0"); | ||
| assertThrows(RuntimeException.class, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.