implementation of tests for fruitshop #801

sonyasapsan · 2023-09-25T12:42:39Z

No description provided.

Andriy-dz · 2023-09-27T09:32:10Z

src/test/java/fruitshop/service/serviceimpl/DataParserImplTest.java

+import org.junit.jupiter.api.Test;
+
+class DataParserImplTest {
+    private List<String> stringList;


you don't need these variables as class fields. Create it and execute it in test methods

Andriy-dz · 2023-09-27T09:35:02Z

src/test/java/fruitshop/service/serviceimpl/DataParserImplTest.java

+
+    @Test
+    void parseStringToDataObject_parameterIsNull_notOk() {
+        assertThrows(NullPointerException.class, () -> dataParser.parseStringToDataObject(null));


you have no business logic that sells this error, so this test is not correct

Andriy-dz · 2023-09-27T09:37:25Z

src/test/java/fruitshop/service/serviceimpl/FileReaderImplTest.java

+        String fileName = null;
+        assertThrows(NullPointerException.class, () -> reader.readDataFromFile(fileName));


Suggested change

String fileName = null;

assertThrows(NullPointerException.class, () -> reader.readDataFromFile(fileName));

assertThrows(NullPointerException.class, () -> reader.readDataFromFile(null));

Andriy-dz · 2023-09-27T09:37:37Z

src/test/java/fruitshop/service/serviceimpl/FileReaderImplTest.java

+        String fileName = "hello";
+        assertThrows(RuntimeException.class, () -> reader.readDataFromFile(fileName));


Suggested change

String fileName = "hello";

assertThrows(RuntimeException.class, () -> reader.readDataFromFile(fileName));

assertThrows(RuntimeException.class, () -> reader.readDataFromFile("hello"));

Andriy-dz · 2023-09-27T09:37:50Z

src/test/java/fruitshop/service/serviceimpl/FileReaderImplTest.java

+    }
+
+    @Test
+    void readDataFromFile_filaNameDoesntExist_notOk() {


Suggested change

void readDataFromFile_filaNameDoesntExist_notOk() {

void readDataFromFile_fileNameDoesntExist_notOk() {

Andriy-dz · 2023-09-27T09:39:10Z

src/test/java/fruitshop/service/serviceimpl/FruitServiceImplTest.java

+    private static Map<Operation, OperationHandler> operationHandlerMap;
+    private List<FruitTransaction> dataLinesObj;
+    private FruitService fruitService;
+
+    @BeforeAll
+    static void beforeAll() {
+        operationHandlerMap = new HashMap<>();
+        operationHandlerMap.put(Operation.BALANCE, new BalanceOperationHandler());
+        operationHandlerMap.put(Operation.PURCHASE, new PurchaseOperationHandler());
+        operationHandlerMap.put(Operation.SUPPLY, new SupplyOperationHandler());
+        operationHandlerMap.put(Operation.RETURN, new ReturnOperationHandler());
+    }
+
+    @BeforeEach
+    void setUp() {
+        Storage.setStorage(new HashMap<>());
+        fruitService = new FruitServiceImpl(operationHandlerMap);
+        dataLinesObj = new ArrayList<>();
+    }


Suggested change

private static Map<Operation, OperationHandler> operationHandlerMap;

private List<FruitTransaction> dataLinesObj;

private FruitService fruitService;

@BeforeAll

static void beforeAll() {

operationHandlerMap = new HashMap<>();

operationHandlerMap.put(Operation.BALANCE, new BalanceOperationHandler());

operationHandlerMap.put(Operation.PURCHASE, new PurchaseOperationHandler());

operationHandlerMap.put(Operation.SUPPLY, new SupplyOperationHandler());

operationHandlerMap.put(Operation.RETURN, new ReturnOperationHandler());

}

@BeforeEach

void setUp() {

Storage.setStorage(new HashMap<>());

fruitService = new FruitServiceImpl(operationHandlerMap);

dataLinesObj = new ArrayList<>();

}

private FruitService fruitService;

@BeforeAll

static void beforeAll() {

Map<Operation, OperationHandler> operationHandlerMap;

operationHandlerMap = new HashMap<>();

operationHandlerMap.put(Operation.BALANCE, new BalanceOperationHandler());

operationHandlerMap.put(Operation.PURCHASE, new PurchaseOperationHandler());

operationHandlerMap.put(Operation.SUPPLY, new SupplyOperationHandler());

operationHandlerMap.put(Operation.RETURN, new ReturnOperationHandler());

fruitService = new FruitServiceImpl(operationHandlerMap);

}

FruitService isn't static, so I can't initialize it in beforeAll method

make it static)

Andriy-dz · 2023-09-27T09:41:46Z

src/test/java/fruitshop/service/serviceimpl/FruitServiceImplTest.java

+
+    @Test
+    void processFruits_validCase_ok() {
+        dataLinesObj.add(new FruitTransaction(Operation.BALANCE, "banana", 20));


add the logic to add the object to Storage and use it here.

Andriy-dz · 2023-09-27T09:42:20Z

src/test/java/fruitshop/service/serviceimpl/FruitServiceImplTest.java

+
+    @Test
+    void processFruits_nullAsParameter_notOk() {
+        assertThrows(NullPointerException.class, () -> fruitService.processFruits(null));


you have no business logic that sells this error, so this test is not correct

Andriy-dz · 2023-09-27T09:42:42Z

src/test/java/fruitshop/service/serviceimpl/ReportCreatorImplTest.java

+    @Test
+    void createReport_nullAsParameter_notOk() {
+        Storage.setStorage(null);
+        assertThrows(NullPointerException.class, () -> reportCreator.createReport());


you have no business logic that sells this error, so this test is not correct

Andriy-dz · 2023-09-27T09:43:09Z

src/test/java/fruitshop/strategy/OperationStrategyTest.java

+
+    @Test
+    void getOperationHandler_validCase_ok() {
+        OperationHandler expected = new SupplyOperationHandler();


make it class field

Andriy-dz · 2023-10-09T06:39:27Z

src/test/java/fruitshop/strategy/OperationStrategyTest.java

+    private OperationStrategy operationStrategy;
+    private OperationHandler expected;
+
+    @BeforeEach


make field static and use BeforeAll

Andriy-dz · 2023-10-09T06:39:44Z

src/test/java/fruitshop/service/serviceimpl/FruitServiceImplTest.java

+    private static Map<Operation, OperationHandler> operationHandlerMap;
+    private List<FruitTransaction> dataLinesObj;
+    private FruitService fruitService;
+
+    @BeforeAll
+    static void beforeAll() {
+        operationHandlerMap = new HashMap<>();
+        operationHandlerMap.put(Operation.BALANCE, new BalanceOperationHandler());
+        operationHandlerMap.put(Operation.PURCHASE, new PurchaseOperationHandler());
+        operationHandlerMap.put(Operation.SUPPLY, new SupplyOperationHandler());
+        operationHandlerMap.put(Operation.RETURN, new ReturnOperationHandler());
+    }
+
+    @BeforeEach
+    void setUp() {
+        Storage.setStorage(new HashMap<>());
+        fruitService = new FruitServiceImpl(operationHandlerMap);
+        dataLinesObj = new ArrayList<>();
+    }


make it static)

implementation of tests fro fruitshop

acac243

Andriy-dz suggested changes Sep 27, 2023

View reviewed changes

improved my tests

00cd0c5

sonyasapsan requested a review from Andriy-dz October 6, 2023 14:46

Andriy-dz approved these changes Oct 9, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implementation of tests for fruitshop #801

implementation of tests for fruitshop #801

sonyasapsan commented Sep 25, 2023

Andriy-dz Sep 27, 2023

Andriy-dz Sep 27, 2023

Andriy-dz Sep 27, 2023

Andriy-dz Sep 27, 2023

Andriy-dz Sep 27, 2023

Andriy-dz Sep 27, 2023

sonyasapsan Oct 6, 2023

Andriy-dz Oct 9, 2023

Andriy-dz Sep 27, 2023

Andriy-dz Sep 27, 2023

Andriy-dz Sep 27, 2023

Andriy-dz Sep 27, 2023

Andriy-dz Oct 9, 2023

Andriy-dz Oct 9, 2023

		String fileName = null;
		assertThrows(NullPointerException.class, () -> reader.readDataFromFile(fileName));

		String fileName = "hello";
		assertThrows(RuntimeException.class, () -> reader.readDataFromFile(fileName));

	void readDataFromFile_filaNameDoesntExist_notOk() {
	void readDataFromFile_fileNameDoesntExist_notOk() {

implementation of tests for fruitshop #801

Are you sure you want to change the base?

implementation of tests for fruitshop #801

Conversation

sonyasapsan commented Sep 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment