done the task #823
Open
done the task #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhdnchui
suggested changes
Oct 31, 2023
src/test/java/db/StorageTest.java
Outdated
| } | ||
|
|
||
| @Test | ||
| public void putFruitToStorage_NullFruit_notOk() { |
There was a problem hiding this comment.
Use lower case letter after _.
Make sure use it everywhere.
| private final List<String> lines = new ArrayList<>(); | ||
| private final Writer reportWrite = new WriterImpl(); | ||
|
|
||
| @BeforeEach |
kshuryhin
suggested changes
Oct 31, 2023
Comment on lines
56
to
81
| public void testValidDailyReportProcessing() { | ||
| fruitTransactionService.makeReport(transactionList); | ||
| assertEquals(EXPECTED_RESULT, (long) Storage.getFruitsNumber(APPLE)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testNegativeAmountInTransaction() { | ||
| final List<FruitTransaction> originalList = new ArrayList<>(transactionList); | ||
| transactionList.clear(); | ||
| transactionList.add(new FruitTransaction(FruitTransaction | ||
| .Operation.BALANCE, APPLE, AMOUNT)); | ||
| transactionList.add(new FruitTransaction(FruitTransaction | ||
| .Operation.PURCHASE, APPLE, AMOUNT + PLUS_INDEX)); | ||
| assertNotEquals(originalList, transactionList); | ||
| } | ||
|
|
||
| @Test | ||
| public void testZeroAmountInTransaction() { | ||
| final List<FruitTransaction> originalList = new ArrayList<>(transactionList); | ||
| transactionList.clear(); | ||
| transactionList.add(new FruitTransaction(FruitTransaction | ||
| .Operation.BALANCE, APPLE, AMOUNT)); | ||
| transactionList.add(new FruitTransaction(FruitTransaction | ||
| .Operation.PURCHASE, APPLE, 0)); | ||
| assertNotEquals(originalList, transactionList); | ||
| } |
There was a problem hiding this comment.
Please, follow the method's naming you've chosen to make code more consistent
| } | ||
|
|
||
| @Test | ||
| public void testDoOperation_AddsTransactionQuantityToStorage() { |
There was a problem hiding this comment.
Minor, but I believe test prefix in method names is not needed here and in other operation tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.