Write tests with more than 80% coverage #834
Conversation
Fixes for Java CI tests
Fixes for Java CI tests
|
|
||
| @Test | ||
| void listOperationsFromCsv_validText_ok() { | ||
| List<String> inputList = List.of("b,banana,20", "b,apple,100"); |
There was a problem hiding this comment.
I think it's better to create String of operation before each method or like constant, and use in each testMethods and in that way avoid code duplication
| balanceOperation = new GoodsOperation(balanceOperation.getTransactionType(), | ||
| null, | ||
| balanceOperation.getQuantity()); | ||
| Assertions.assertThrows(RuntimeException.class, |
There was a problem hiding this comment.
It's better to throw more specific exception or check exception message like example bellow:
@test
public void whenExceptionThrown_thenAssertionSucceeds() {
Exception exception = assertThrows(NumberFormatException.class, () -> {
Integer.parseInt("1a");
});
String expectedMessage = "For input string";
String actualMessage = exception.getMessage();
assertTrue(actualMessage.contains(expectedMessage));
}
| purchaseOperation = new GoodsOperation(purchaseOperation.getTransactionType(), | ||
| null, | ||
| purchaseOperation.getQuantity()); | ||
| Assertions.assertThrows(RuntimeException.class, |
There was a problem hiding this comment.
It's better to throw more specific exception or check exception message
| returnOperation = new GoodsOperation(returnOperation.getTransactionType(), | ||
| null, | ||
| returnOperation.getQuantity()); | ||
| Assertions.assertThrows(RuntimeException.class, |
There was a problem hiding this comment.
It's better to throw more specific exception or check exception message
| supplyOperation = new GoodsOperation(supplyOperation.getTransactionType(), | ||
| null, | ||
| supplyOperation.getQuantity()); | ||
| Assertions.assertThrows(RuntimeException.class, |
There was a problem hiding this comment.
It's better to throw more specific exception or check exception message
| @AfterEach | ||
| void tearDown() { | ||
| } |
There was a problem hiding this comment.
Just wondering if we really need that one if it does nothing?
| for (int i = 0; i < actual.size(); i++) { | ||
| Assertions.assertEquals(expected.get(i), actual.get(i)); | ||
| } |
There was a problem hiding this comment.
| for (int i = 0; i < actual.size(); i++) { | |
| Assertions.assertEquals(expected.get(i), actual.get(i)); | |
| } | |
| assertIterableEquals(expected, actual); |
| for (int i = 0; i < expectedList.size(); i++) { | ||
| Assertions.assertEquals(expectedList.get(i), actualList.get(i)); | ||
| } |
There was a problem hiding this comment.
| for (int i = 0; i < expectedList.size(); i++) { | |
| Assertions.assertEquals(expectedList.get(i), actualList.get(i)); | |
| } | |
| assertIterableEquals(expectedList, actualList); |
| for (int i = 0; i < actualList.size(); i++) { | ||
| Assertions.assertEquals(expectedList.get(i), actualList.get(i)); | ||
| } |
There was a problem hiding this comment.
| for (int i = 0; i < actualList.size(); i++) { | |
| Assertions.assertEquals(expectedList.get(i), actualList.get(i)); | |
| } | |
| assertIterableEquals(expectedList, actualList); |
| for (int i = 0; i < actualList.size(); i++) { | ||
| Assertions.assertEquals(expectedsList.get(i), actualList.get(i)); | ||
| } |
There was a problem hiding this comment.
| for (int i = 0; i < actualList.size(); i++) { | |
| Assertions.assertEquals(expectedsList.get(i), actualList.get(i)); | |
| } | |
| assertIterableEquals(expectedsList, actualList); |
No description provided.