Done the task, cover all code by JUniy5 test. Try to do correct, now … #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have line coverage more than 90%
…have line coverage more than 90%. Fix problem with git, change some name of test
…have line coverage more than 90%. Fix problem with git, change some name of test
kerrrusha
approved these changes
Nov 5, 2023
Comment on lines
+24
to
+27
| FruitTransaction validTransaction = | ||
| new FruitTransaction(DEFAULT_OPERATION, DEFAULT_NAME, DEFAULT_QUANTITY); | ||
| assertEquals(DEFAULT_TRANSACTION, validTransaction); | ||
| } |
There was a problem hiding this comment.
Suggested change
| FruitTransaction validTransaction = | |
| new FruitTransaction(DEFAULT_OPERATION, DEFAULT_NAME, DEFAULT_QUANTITY); | |
| assertEquals(DEFAULT_TRANSACTION, validTransaction); | |
| } | |
| FruitTransaction actualTransaction = | |
| new FruitTransaction(DEFAULT_OPERATION, DEFAULT_NAME, DEFAULT_QUANTITY); | |
| assertEquals(DEFAULT_TRANSACTION, actualTransaction); | |
| } |
Comment on lines
+13
to
+21
| private static Map<FruitTransaction.Operation, OperationHandlers> operationHandlersMap = | ||
| new HashMap<>() { | ||
| { | ||
| put(FruitTransaction.Operation.BALANCE, new BalanceTypeHandler()); | ||
| } | ||
| }; | ||
|
|
||
| private static final OperationStrategy OPERATION_STRATEGY | ||
| = new OperationStrategyImpl(operationHandlersMap); |
There was a problem hiding this comment.
this should be done in setUp method
Suggested change
| private static Map<FruitTransaction.Operation, OperationHandlers> operationHandlersMap = | |
| new HashMap<>() { | |
| { | |
| put(FruitTransaction.Operation.BALANCE, new BalanceTypeHandler()); | |
| } | |
| }; | |
| private static final OperationStrategy OPERATION_STRATEGY | |
| = new OperationStrategyImpl(operationHandlersMap); | |
| private static OperationStrategy strategy; | |
| @BeforeAll | |
| static void setUp() { | |
| Map<FruitTransaction.Operation, OperationHandlers> operationHandlerMap = Map.of(FruitTransaction.Operation.BALANCE, new BalanceTypeHandler()); | |
| strategy = new OperationStrategyImpl(operationHandlerMap); | |
| } |
| void balanceHandleTransaction_ValidData_Ok() { | ||
| OPERATION_HANDLERS.handleTransaction(VALID_FRUIT_TRANSACTION); | ||
| assertEquals(Map.of(VALID_NAME,VALID_QUANTITY).entrySet(),storage.entrySet()); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…have line coverage more than 90%