Solution for jv-fruit-shop-test #838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarasYurkovskyi
approved these changes
Nov 6, 2023
kshuryhin
suggested changes
Nov 6, 2023
| void processTransactions_validTransactions_updatesStorage() { | ||
| FruitTransaction fruitTransaction = new FruitTransaction(); | ||
| fruitTransaction.setOperation(FruitTransactionOperation.BALANCE); | ||
| fruitTransaction.setFruit("banana"); |
There was a problem hiding this comment.
My recommendation here is to move "banana" literal to the constant variable
| } | ||
|
|
||
| @Test | ||
| public void testInvalidStringsToFruitTransactions() { |
There was a problem hiding this comment.
Make sure your test method names are consistent among all tests
|
|
||
| @Test | ||
| public void readFromFile_validFile_ok() { | ||
| String validFilePath = "src/test/resources/test_transaction.csv"; |
There was a problem hiding this comment.
Usually we are extracting path values to the constants. That is also a general recommendation for your code optimization
| Storage.fruitTransactions.put("apple",300); | ||
| String expected = "fruit,quantity" + separator | ||
| + "banana,100" + separator + "apple,300" + separator; | ||
| assertEquals(expected, |
There was a problem hiding this comment.
Call to assertEquals() from Assert should be replaced with a call to a method from org.junit.jupiter.api.Assertions for consistency sake
Comment on lines
27
to
46
| void writeToFile_validPath_ok() { | ||
| String report = "fruit,quantity" + System.lineSeparator() | ||
| + "banana,152" + System.lineSeparator() | ||
| + "apple,90" + System.lineSeparator(); | ||
| String validFilePath = "test_valid_report.csv"; | ||
| writerService.writeToFile(validFilePath,report); | ||
| Path path = Paths.get(validFilePath); | ||
| List<String> strings = null; | ||
| try (Stream<String> lines = Files.lines(path)) { | ||
| strings = lines.collect(Collectors.toList()); | ||
| } catch (IOException e) { | ||
| fail("Exсeption shouldn't be thrown in this test"); | ||
| } | ||
| String[] transactions = report.split(System.lineSeparator()); | ||
| for (int i = 0; i < strings.size(); i++) { | ||
| String expected = strings.get(i); | ||
| assertEquals(expected,transactions[i], | ||
| "transactions differ at element: " + i); | ||
| } | ||
| } |
There was a problem hiding this comment.
Looks too overcomplicated. Consider making it prettier with assertIterableEquals and some some values to constant separation.
mnyshenko
suggested changes
Nov 7, 2023
Comment on lines
21
to
49
| public void setUp() { | ||
| parserService = new ParserServiceImpl(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testValidStringsToFruitTransactions() { | ||
| List<String> inputStrings = Arrays.asList( | ||
| BALANCE_OPERATION_CODE + ",apple,10", | ||
| SUPPLY_OPERATION_CODE + ",banana,20", | ||
| PURCHASE_OPERATION_CODE + ",orange,5", | ||
| RETURN_OPERATION_CODE + ",kiwi,3" | ||
| ); | ||
|
|
||
| List<FruitTransaction> expectedTransactions = Arrays.asList( | ||
| createFruitTransaction(FruitTransactionOperation.BALANCE, "apple", 10), | ||
| createFruitTransaction(FruitTransactionOperation.SUPPLY, "banana", 20), | ||
| createFruitTransaction(FruitTransactionOperation.PURCHASE, "orange", 5), | ||
| createFruitTransaction(FruitTransactionOperation.RETURN, "kiwi", 3) | ||
| ); | ||
|
|
||
| List<FruitTransaction> result = parserService.stringsToFruitTransactions(inputStrings); | ||
|
|
||
| assertEquals(expectedTransactions, result); | ||
| } | ||
|
|
||
| @Test | ||
| public void testInvalidStringToFruitTransactions() { | ||
| List<String> inputStrings = Arrays.asList( | ||
| BALANCE_OPERATION_CODE + ",apple,10", |
There was a problem hiding this comment.
Comment on lines
37
to
52
| try { | ||
| operationHandler.countQuantity(INITIAL_AMOUNT, NEGATIVE_OPERATION_AMOUNT); | ||
| } catch (RuntimeException e) { | ||
| String expected = "Operation amount can not be less than 0"; | ||
| assertEquals(expected, e.getMessage()); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| void countQuantity_negativeCurrentAmount() { | ||
| try { | ||
| operationHandler.countQuantity(NEGATIVE_CURRENT_AMOUNT, OPERATION_AMOUNT); | ||
| } catch (RuntimeException e) { | ||
| String expected = "Current amount can not be less than 0"; | ||
| assertEquals(expected, e.getMessage()); | ||
| } |
There was a problem hiding this comment.
Why don't you use assertThrows() here?
kshuryhin
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.