Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reesolve #1252

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

DankevichMisha
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the FruitShop application! 🎉 Your code is well-structured and meets most of the task requirements. Here are some key points to consider for improvement:

  1. Exception Handling: Consider using a custom exception, such as InvalidDataException, instead of a generic RuntimeException for better error specificity and handling, especially when dealing with IO errors or invalid operation codes.

  2. File Handling: Use try-with-resources in the FileReaderServiceImpl class to ensure resources are closed properly. Also, ensure that file paths are relative and placed in the src/main/resources folder as recommended.

  3. Encapsulation: Improve encapsulation in the FruitTransaction class by making fields private and providing controlled access through getters and setters.

  4. SOLID Principles: Ensure each class and method has a single responsibility, and high-level modules do not depend on low-level modules.

Your code is on the right track, and addressing these points will enhance its robustness and maintainability. Keep up the good work and continue learning from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants