Created structure that reads data from csv file, inside created proce… #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 4, 2023 23:49
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file
Rommelua
suggested changes
Oct 5, 2023
Comment on lines
23
to
24
| String inputFile = "src/main/resources/input.csv"; | ||
| String outputFile = "src/main/resources/output.csv"; |
Comment on lines
31
to
35
| for (String line : inputLines) { | ||
| line = line.trim(); | ||
| String[] transaction = line.split("\\s*,\\s*"); | ||
| fruitService.processTransaction(transaction); | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (String line : inputLines) { | |
| line = line.trim(); | |
| String[] transaction = line.split("\\s*,\\s*"); | |
| fruitService.processTransaction(transaction); | |
| } | |
| List<FruitTransaction> transactions = parseServise.parseTransactions(inputLines ); | |
| fruitService.processTransaction(transactions); |
| String[] transaction = line.split("\\s*,\\s*"); | ||
| fruitService.processTransaction(transaction); | ||
| } | ||
| List<String> report = generateReport(storage); |
There was a problem hiding this comment.
Suggested change
| List<String> report = generateReport(storage); | |
| List<String> report = reportService.generateReport(); |
|
|
||
| public class Storage { | ||
| private static Storage instance; | ||
| private final Map<String, FruitTransaction> fruitInventory; |
There was a problem hiding this comment.
Suggested change
| private final Map<String, FruitTransaction> fruitInventory; | |
| private final Map<String, Integer> fruitInventory; |
We are keeping Fruits on the storage - not FruitTransactions
Comment on lines
3
to
4
| public class FruitTransaction { | ||
| private int quantity; |
Comment on lines
3
to
4
| public interface FruitService { | ||
| void processTransaction(String[] transaction); |
There was a problem hiding this comment.
Suggested change
| public interface FruitService { | |
| void processTransaction(String[] transaction); | |
| public interface FruitService { | |
| void processTransactions(List<FruitTransaction> transactions); |
added 6 commits
October 8, 2023 01:06
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file
sokimaaa
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ss classes that can do supply, purchase & return, then creates a report and write it in output csv file