used service, strategy packages #960
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan95kos
suggested changes
Oct 24, 2023
Comment on lines
+9
to
+10
|
|
||
|
|
| } | ||
| } | ||
| } | ||
|
|
| StringBuilder report = new StringBuilder("fruit,quantity").append(System.lineSeparator()); | ||
| for (Map.Entry<String, Integer> entry : FruitStorage.fruitQuantities.entrySet()) { | ||
| report.append(entry.getKey()) | ||
| .append(",") |
There was a problem hiding this comment.
Suggested change
| .append(",") | |
| .append(SEPARATOR) |
| public class ReportServiceImpl implements ReportService { | ||
| @Override | ||
| public String report() { | ||
| StringBuilder report = new StringBuilder("fruit,quantity").append(System.lineSeparator()); |
There was a problem hiding this comment.
Suggested change
| StringBuilder report = new StringBuilder("fruit,quantity").append(System.lineSeparator()); | |
| StringBuilder report = new StringBuilder(HEADER).append(System.lineSeparator()); |
| FruitStorage.fruitQuantities.put(transaction.getFruit(), transaction.getQuantity()); | ||
| } | ||
| } | ||
|
|
| public interface OperationStrategy { | ||
| OperationHandler get(FruitTransaction.Operation operation); | ||
| } | ||
|
|
| .put(transaction.getFruit(), oldQuantity + transaction.getQuantity()); | ||
| } | ||
| } | ||
|
|
| @@ -0,0 +1,18 @@ | |||
| package core.basesyntax.strategy; | |||
There was a problem hiding this comment.
Move the entire implementation from the strategy package to the impl package
Suggested change
| package core.basesyntax.strategy; | |
| package core.basesyntax.strategy.impl; |
kozhukhovsky
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.