Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #3940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add solution #3940

wants to merge 1 commit into from

Conversation

RHerheman
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • [ x] Changing 'month-lengh' and 'start-day' modifier in the code element
    reflects in changing calendar layout

  • [ x] Each day has no modifiers, only class (eg. calendar__day)

  • [ x] All Typical Mistakes from BEM lesson theory are checked.

  • [ x] Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code is well-structured and meets the core requirements. Just make sure to compile your SCSS into CSS before linking it in your HTML for browser compatibility. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -9,10 +9,44 @@
<title>Calendar</title>
<link
rel="stylesheet"
href="styles/index.scss"
href="styles/main.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stylesheet is linked to a .scss file. Browsers cannot directly interpret SCSS files; they need to be compiled into CSS. Ensure that the SCSS file is compiled to a CSS file and link the resulting CSS file instead.

@@ -0,0 +1,70 @@
@import 'variables';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the 'variables' file contains all the necessary variable definitions such as $block, $gap, $cal-padding, $days, etc., used in this SCSS file.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
There are must be 7 columns for days
image

Also, this part of the task is incomplete
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants