implemented MOYO header #5365
implemented MOYO header #5365
Conversation
There was a problem hiding this comment.
Great job on the Pull Request! 🌟 While there are some suggestions for improvement, such as using classes for styling instead of tag names, providing fallback fonts, adding empty lines for readability, fixing href values, and improving alt text, these are not critical issues and don't significantly impact the functionality or security of your code. Keep these tips in mind for future projects to enhance your code quality! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| href="apple" | ||
| > |
There was a problem hiding this comment.
The href attribute in the anchor tag should start with a '#' symbol when linking to an anchor on the same page. Also, avoid using spaces in the href value.
Done, thanks! |
src/style.css
Outdated
| nav a:hover { | ||
| color: var(--primary-color); | ||
| } | ||
|
|
||
| nav { | ||
| display: flex; | ||
| align-items: center; | ||
| height: 60px; | ||
| } | ||
|
|
||
| nav ul { | ||
| list-style: none; | ||
| padding: 0; | ||
| margin: 0; | ||
| display: flex; | ||
| height: 100%; | ||
| align-items: center; | ||
| } |
src/style.css
Outdated
| content: ''; /* Псевдоелемент не додає текст */ | ||
| display: block; /* Робимо псевдоелемент блоковим */ | ||
| width: 100%; /* Ширина підкреслювання відповідає ширині посилання */ |
There was a problem hiding this comment.
remove all comments. Try to write obvious code that explains all we need without comments)
| display: flex; | ||
| justify-content: space-between; | ||
| width: auto; | ||
| background-color: white; |
There was a problem hiding this comment.
This color is default
| background-color: white; |
DEMO LINK
TEST REPORT LINK