Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moyo Header #5376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Moyo Header #5376

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b3dd4d
add task solution
rssydorenko Sep 17, 2024
61ad6e6
corrected the code
rssydorenko Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://rssydorenko.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://rssydorenko.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
104 changes: 103 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,114 @@
content="ie=edge"
/>
<title>Moyo header</title>
<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
crossorigin="anonymous"
/>

<link
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap"
rel="stylesheet"
/>

<link
rel="stylesheet"
href="./style.css"
/>
</head>
<body>
<h1>Moyo header</h1>
<header class="header">
<a
href="#"
class="logo"
>
<img
src="/src/images/logo.png"
alt="Moyo-logo"
/>
</a>

<nav class="nav">
<ul class="nav_list">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class name 'nav_list' should be 'nav__list' to maintain BEM naming conventions which represent the meaning of the content and not the styles or tag names.

<li class="nav_item">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class name 'nav_item' should be 'nav__item' to maintain BEM naming conventions which represent the meaning of the content and not the styles or tag names.

<a
href="#apple"
class="nav_link is-active"
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class name 'nav_link' should be 'nav__link' to maintain BEM naming conventions which represent the meaning of the content and not the styles or tag names.

Apple
</a>
</li>

<li class="nav_item">
<a
href="#samsung"
class="nav_link"
>
Samsung
</a>
</li>

<li class="nav_item">
<a
href="#smartphones"
class="nav_link"
>
Smartphones
</a>
</li>

<li class="nav_item">
<a
href="#laptops-computers"
class="nav_link"
data-qa="hover"
>
Laptops & Computers
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use spaces in the <a> tag's href property. The correct value should be '#laptops-computers' without the space.

</a>
</li>

<li class="nav_item">
<a
href="#gadgets"
class="nav_link"
>
Gadgets
</a>
</li>

<li class="nav_item">
<a
href="#tablets"
class="nav_link"
>
Tablets
</a>
</li>

<li class="nav_item">
<a
href="#photo"
class="nav_link"
>
Photo
</a>
</li>

<li class="nav_item">
<a
href="#video"
class="nav_link"
>
Video
</a>
</li>
</ul>
</nav>
</header>
</body>
</html>
73 changes: 72 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,74 @@
body {
* {
margin: 0;
padding: 0;
box-sizing: border-box;
list-style: none;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use * selector (it impacts performance). Set styles only for elements that require them. Zeroing out your margins, paddings or other styles with '*' is still inefficient for the browser.


a {
text-decoration: none;
color: inherit;
}

html {
font-size: 16px;
font-family: Roboto, sans-serif;
font-style: normal;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to use fallback fonts - alternative font-family in case the main one doesn't work. For example, font-family: Roboto, Arial, sans-serif;.

}

.header {
display: flex;
align-items: center;
justify-content: space-between;
max-width: 1200px;
margin: 0 auto;
padding: 0 50px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
max-width: 1200px;
margin: 0 auto;
width: 100%;
box-sizing: border-box;

}

.logo {
display: block;
height: 40px;
width: 40px;
}

.nav_list {
display: flex;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class names should represent the meaning of the content, not the styles or tag names. Here, .nav_list should be .nav__list to follow the BEM naming convention.

}

.nav_item {
color: black;
}

.nav_item:not(:last-child) {
margin-right: 20px;
}

.nav_item:hover {
color: #00acdc;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a variable for repeated color and use it everywhere


.nav_link {
position: relative;
display: flex;
align-items: center;
height: 60px;
margin: auto;
text-transform: uppercase;
font-size: 12px;
line-height: 16px;
font-weight: 500;
}

.is-active {
color: #00acdc;
}

.is-active::after {
content: '';
position: absolute;
width: 100%;
height: 4px;
bottom: 0;
left: 0;
background-color: #00acdc;
}
Loading