Ready header moyon #5388
Ready header moyon #5388
Conversation
StronDator
commented
Sep 19, 2024
StronDator
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Great job on the HTML structure! 🌟 While there are some minor formatting issues and inconsistencies, they don't significantly impact the functionality or security of your code. In the future, pay attention to consistent indentation, attribute formatting, and the use of fallback fonts. Keep up the good work! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <header class="header"> | ||
| <a | ||
| class="link" | ||
| href="../src/index.html" |
There was a problem hiding this comment.
Don't use spaces in <a> tag's href property. The href attribute should not point to the index.html itself as it is unnecessary. If you intend to link to the top of the page, use href="#".
| <li class="menu-item"> | ||
| <a | ||
| class="menu-link nav-link link is-active" | ||
| href="#Apple" |
There was a problem hiding this comment.
Anchor links should start with the # symbol followed by the id of the element you want to link to. The value #Apple should be in lowercase to match the id exactly, use #apple instead.
| <a | ||
| class="menu-link nav-link link" | ||
| data-qa="hover" | ||
| href="#Laptops-Computers" |
There was a problem hiding this comment.
Don't use spaces in <a> tag's href property. Instead of #Laptops-Computers, use #laptops-computers (all lowercase) to ensure consistency.
| <a | ||
| class="link" | ||
| href="../src/index.html" | ||
| > | ||
| <img | ||
| src="./images/logo.png" | ||
| alt="moyo logo" |
There was a problem hiding this comment.
Keep your attributes correctly formatted. When an HTML element has multiple attributes, each attribute should start on a new line with 2-space indentation related to the tag.
| <a | ||
| class="menu-link nav-link link is-active" | ||
| href="#Apple" | ||
| > | ||
| Apple | ||
| </a> |
There was a problem hiding this comment.
Keep your attributes correctly formatted as you did in lines 33-39. Each attribute should start on a new line with 2-space indentation.
| h1, | ||
| h2, | ||
| h3, | ||
| h4, | ||
| h5, | ||
| h6, | ||
| p { | ||
| margin-top: 0; | ||
| margin-bottom: 0; |
There was a problem hiding this comment.
Be consistent with your vertical margins (Add only top or only bottom margin, but not both). It's best to pick one direction (either top or bottom) for vertical margins to prevent issues with margin collapsing and to maintain consistency throughout the stylesheet.
| ul, | ||
| ol { | ||
| padding-left: 0; | ||
| margin-top: 0; | ||
| margin-bottom: 0; |
There was a problem hiding this comment.
Similar to the previous comment, be consistent with your vertical margins for lists. Choose either top or bottom margin to apply to your elements.
| body { | ||
| font-family: Roboto, sans-serif; |
There was a problem hiding this comment.
Remember to use fallback fonts - alternative font-family in case the main one doesn't work. For example, 'font-family: Roboto, Arial, sans-serif;' ensures that if 'Roboto' is not available, the browser will try to use 'Arial' before falling back to the default 'sans-serif' font.
| .header { | ||
| padding-top: 10px; | ||
| padding-bottom: 10px; | ||
| margin-right: 50px; | ||
| margin-left: 50px; | ||
| display: flex; | ||
| justify-content: space-between; |
There was a problem hiding this comment.
Don't fix container size (if there is no such a requirement). In this case, setting explicit margins might not be necessary if you want the container to be sized by its content. If there's no requirement for fixed margins, consider using padding within the container or setting max-width instead.
| .nav-link:active::after { | ||
| position: absolute; | ||
| left: 0; | ||
| bottom: -18px; |
There was a problem hiding this comment.
| bottom: -18px; | |
| bottom: 0; |
StronDator
requested review from
anastasiiavorobiova and
mateacademy-ai-mentor
| <ul class="menu list"> | ||
| <li class="menu-item"> | ||
| <a | ||
| class="menu-link nav-link link is-active" |
There was a problem hiding this comment.
why do you need so many classes
| class="menu-link nav-link link is-active" | |
| class="nav-link is-active" |
| </li> | ||
| <li class="menu-item"> | ||
| <a | ||
| class="menu-link nav-link link" |
There was a problem hiding this comment.
| class="menu-link nav-link link" | |
| class="nav-link" |
| .header { | ||
| padding-top: 10px; | ||
| padding-bottom: 10px; | ||
| margin-right: 50px; | ||
| margin-left: 50px; |
There was a problem hiding this comment.
| .header { | |
| padding-top: 10px; | |
| padding-bottom: 10px; | |
| margin-right: 50px; | |
| margin-left: 50px; | |
| .header { | |
| padding: 0 50px; |
better to use padding here instead of a margin
padding is applied inside the element, whereas margins affect the space outside the element.
|
|
||
| .menu { | ||
| display: flex; | ||
| gap: 20px; |
| <ul class="menu list"> | ||
| <li class="menu-item"> | ||
| <a | ||
| class="menu-link nav-link link is-active" |
There was a problem hiding this comment.
if the element has an is-active class then this element should have that line and a blue color
