Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moyo #5619

Closed
wants to merge 3 commits into from
Closed

Moyo #5619

wants to merge 3 commits into from

Conversation

QuantumCoder228
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 While you've made great progress, there are a few critical issues that need to be addressed to fully meet the task requirements. Here are the key points to focus on:

  1. Font Usage: Ensure you're using the Roboto font as specified in the task, instead of Arial.
  2. Semantic Tags: Wrap the <img> tag for the logo in a link to enhance accessibility and meet the task requirements.
  3. Active Link Class: Use the class is-active for the active link instead of active.
  4. Data Attribute: Add the data-qa="hover" attribute to the 4th link (Laptops & computers).
  5. CSS Variable for Blue Color: Implement a CSS variable for the blue color to improve maintainability.
  6. Flexbox Gap Property: Avoid using the flex gap property as per the task constraints.
  7. HTML Formatting: Adjust the HTML indentation to 2 spaces for consistency.

These changes will help ensure your code meets the core requirements and enhances its functionality. Keep up the great work, and feel free to reach out if you have any questions! 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@QuantumCoder228 QuantumCoder228 changed the title Moyo задание Moyo Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants