add task solution #5622
add task solution #5622
Conversation
JosielLinhar
commented
Oct 30, 2024
JosielLinhar
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Great job on meeting most of the task requirements! 🎉 While there are a few minor issues, such as the use of tag names in CSS selectors and the placeholder href attributes, these do not critically impact the functionality. Keep up the good work and consider these suggestions for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <link | ||
| rel="preconnect" | ||
| href="https://fonts.googleapis.com" | ||
| /> | ||
| <link | ||
| rel="preconnect" | ||
| href="https://fonts.gstatic.com" |
There was a problem hiding this comment.
Consider adding the 'crossorigin' attribute to the 'preconnect' links for Google Fonts to improve performance. Example: <link rel="preconnect" href="https://fonts.googleapis.com" crossorigin>.
| <h1>Moyo header</h1> | ||
| <header class="header"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
The 'href' attribute is currently set to '#', which is a placeholder. Consider updating it to the actual URL if available.
| <li class="list-item"> | ||
| <a | ||
| class="is-active item-link" | ||
| href="#" |
There was a problem hiding this comment.
The 'href' attribute is currently set to '#', which is a placeholder. Consider updating it to the actual URL if available.
| <li class="list-item"> | ||
| <a | ||
| class="item-link" | ||
| href="#" |
There was a problem hiding this comment.
The 'href' attribute is currently set to '#', which is a placeholder. Consider updating it to the actual URL if available.
| <li class="list-item"> | ||
| <a | ||
| class="item-link" | ||
| href="#" |
There was a problem hiding this comment.
The 'href' attribute is currently set to '#', which is a placeholder. Consider updating it to the actual URL if available.
| <li class="list-item"> | ||
| <a | ||
| class="item-link" | ||
| href="#" |
There was a problem hiding this comment.
The 'href' attribute is currently set to '#', which is a placeholder. Consider updating it to the actual URL if available.
| <li class="list-item"> | ||
| <a | ||
| class="item-link" | ||
| href="#" |
There was a problem hiding this comment.
The 'href' attribute is currently set to '#', which is a placeholder. Consider updating it to the actual URL if available.
| margin: 0; | ||
| padding: 0; | ||
| border: 0; | ||
| font-size: 100%; |
There was a problem hiding this comment.
Setting 'font-size: 100%' in the reset styles is generally fine, but be aware that it might not be necessary for all elements. Consider if this is needed for every element listed.
| padding: 0; | ||
| border: 0; | ||
| font-size: 100%; | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
The 'box-sizing: border-box' is a good practice for layout consistency, but ensure that it doesn't conflict with any specific design requirements you might have.
| display: flex; | ||
| align-items: center; | ||
| height: 60px; | ||
| font-family: Roboto, sans-serif; |
There was a problem hiding this comment.
Ensure that the 'Roboto' font is correctly loaded in your HTML file. This is crucial for the font-family declaration to work as expected.
