add task solution #5667
add task solution #5667
Conversation
Arsenii34
commented
Nov 10, 2024
Arsenii34
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 However, there are a few critical issues that need to be addressed before we can approve the pull request:
-
HTML Structure and Semantics:
- The
<header>tag is incorrectly nested within the<nav>tag. This affects the semantic structure of your HTML and should be corrected by placing the<header>as a top-level element. - The logo image should be wrapped in a link to improve navigation and accessibility.
- The
-
CSS Issues:
- There are syntax errors, such as a missing semicolon in the
.containerclass and incorrect usage of CSS variables (e.g.,#var(--blue-color)should bevar(--blue-color)). - The
a.is-active::afterselector has incorrect and duplicate properties that need to be fixed. - The
text-transform: uppercase;is applied to thebody, which is not ideal and should be limited to specific elements.
- There are syntax errors, such as a missing semicolon in the
-
Task-Specific Requirements:
- The
is-activeclass is not applied to any link, which is a core requirement of the task.
- The
-
General Observations:
- Correct the typo in the
hrefattribute of the first list item link. - Ensure consistent use of CSS variables and correct any misspellings, such as
conteinertocontainer.
- Correct the typo in the
Please address these issues to ensure the functionality and requirements of the task are fully met. Once these changes are made, feel free to resubmit for review. Keep up the great work, and don't hesitate to reach out if you need any help! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| <header class="conteiner"> | ||
| <img src="src/images/logo.png" alt="Logotip" class="logo"> | ||
| <ul> | ||
| <li><a href="#sectionnpm run lint" class="apple text">Apple</a></li> |
There was a problem hiding this comment.
There seems to be a typo in the href attribute of the first list item link. The value '#sectionnpm run lint' is likely incorrect and should be corrected to a valid section ID or URL, such as '#section'.
src/style.css
Outdated
| } | ||
| .container{ | ||
| display: flex; | ||
| background-color:white |
There was a problem hiding this comment.
There is a missing semicolon at the end of the 'background-color' property. This could cause issues with the CSS parsing.
src/style.css
Outdated
| line-height: 14px; | ||
| } | ||
| a.is-active::after{ | ||
| color: #var(--blue-color); |
There was a problem hiding this comment.
The color property is incorrectly using '#var(--blue-color)'. The '#' should be removed to correctly use the CSS variable: 'color: var(--blue-color);'.
src/style.css
Outdated
|
|
||
|
|
||
| .laptops{ | ||
| color:#var(--blue-color); |
There was a problem hiding this comment.
Similar to the previous comment, the color property is incorrectly using '#var(--blue-color)'. Remove the '#' to correctly use the CSS variable: 'color: var(--blue-color);'.
src/style.css
Outdated
| .text{ | ||
| margin-bottom: 30px; | ||
| justify-content: end; | ||
| font-family: 'Roboto' sans-serif; |
There was a problem hiding this comment.
There is a missing comma between 'Roboto' and 'sans-serif'. It should be 'font-family: 'Roboto', sans-serif;'.
There was a problem hiding this comment.
между Roboto и sans-serif нужна просто запятая или ещё пробел
src/style.css
Outdated
|
|
||
| a.active::after { | ||
| content: ''; | ||
| background-color: #var(--blue-color); |
There was a problem hiding this comment.
The background-color property is incorrectly using '#var(--blue-color)'. Remove the '#' to correctly use the CSS variable: 'background-color: var(--blue-color);'.
2 similar comments
