develop #5669
develop #5669
Conversation
There was a problem hiding this comment.
Great job on your submission! 🎉 Your code meets most of the task requirements, and it's clear you've put in a lot of effort. Here are a few areas to focus on for improvement:
-
Navigation Links: All links currently point to 'index.html'. Ensure they direct to the correct pages if they are meant to navigate elsewhere.
-
CSS Variable for Blue Color: Define a CSS variable for the blue color
#00acdcand use it throughout your CSS for consistency. -
Uppercase Text: Use CSS to transform text to uppercase instead of typing it in uppercase in HTML.
-
Pseudo-element for Blue Line: Implement a pseudo-element for the blue line below the active link to enhance your design.
-
HTML Formatting: Keep lines within 80 characters for better readability.
-
Unused Font: Remove the Manrope font link if it's not being used.
-
Image Path: Verify the image path
/src/images/logo.pngto ensure it loads correctly.
These improvements will help you refine your skills and produce even better code in the future. Keep up the great work and continue learning from each experience! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <ul class="nav__list"> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="index.html" |
There was a problem hiding this comment.
All navigation links currently point to 'index.html'. If these links are meant to navigate to different pages, you should update the 'href' attributes to the correct URLs.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="index.html" |
There was a problem hiding this comment.
All navigation links currently point to 'index.html'. If these links are meant to navigate to different pages, you should update the 'href' attributes to the correct URLs.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="index.html" |
There was a problem hiding this comment.
All navigation links currently point to 'index.html'. If these links are meant to navigate to different pages, you should update the 'href' attributes to the correct URLs.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="index.html" |
There was a problem hiding this comment.
All navigation links currently point to 'index.html'. If these links are meant to navigate to different pages, you should update the 'href' attributes to the correct URLs.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="index.html" |
There was a problem hiding this comment.
All navigation links currently point to 'index.html'. If these links are meant to navigate to different pages, you should update the 'href' attributes to the correct URLs.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="index.html" |
There was a problem hiding this comment.
All navigation links currently point to 'index.html'. If these links are meant to navigate to different pages, you should update the 'href' attributes to the correct URLs.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="index.html" |
There was a problem hiding this comment.
All navigation links currently point to 'index.html'. If these links are meant to navigate to different pages, you should update the 'href' attributes to the correct URLs.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="index.html" |
There was a problem hiding this comment.
All navigation links currently point to 'index.html'. If these links are meant to navigate to different pages, you should update the 'href' attributes to the correct URLs.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️