Solution of the challenge Moyo Header #5673
Conversation
There was a problem hiding this comment.
Thank you for your hard work! 😊 There are a few critical issues that need to be addressed before we can approve the changes. The <a> tag for the logo is missing an href attribute, which is essential for it to function as a link. Additionally, there's a typo in the CSS variable name --header-heigth that needs correction to ensure styles are applied correctly. Once these are fixed, your code will be in great shape! Keep up the great effort! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| <link | ||
| rel="stylesheet" | ||
| href="./style.css" | ||
| /> | ||
| </head> | ||
| <body> | ||
| <header class="header"> | ||
| <a class="logo__link"> |
There was a problem hiding this comment.
The <a> tag for the logo lacks an href attribute. This attribute is necessary for the link to function properly. Consider adding a valid URL or # if it's meant to be a placeholder.
| <a | ||
| class="nav__link" | ||
| data-qa="hover" |
There was a problem hiding this comment.
The data-qa attribute is used for testing purposes. Ensure that this attribute is necessary and correctly implemented for your testing framework. If not needed, it can be removed.
| } | ||
|
|
||
| html { | ||
| --header-heigth: 60px; |
There was a problem hiding this comment.
There is a typo in the CSS variable name --header-heigth. It should be corrected to --header-height to ensure consistency and avoid potential issues in the styles that rely on this variable.
No description provided.